VuFind

Finish implementation of Search Object

Details

  • Type: Improvement Improvement
  • Status: Resolved Resolved
  • Priority: Major Major
  • Resolution: Fixed
  • Affects Version/s: None
  • Fix Version/s: 1.0
  • Component/s: Search
  • Labels:
    None

Description

The Search Object will centralize search-related functionality (particularly URL generation) that is currently scattered through the code to allow easier maintenance and customization.

Issue Links

This issue incorporates:
VUFIND-130 Search within is broken. Major Resolved
VUFIND-3 Search History does not keep track of facets Major Resolved
VUFIND-7 RSS feed omits narrowing filters Major Resolved
VUFIND-181 Advanced search queries are handled incorrectly by the spellchecker Major Resolved
VUFIND-22 Advanced search not working when you enter more than one search term in each search box Major Resolved
VUFIND-114 "Get RSS feed" not working since move to JSON response Minor Resolved
VUFIND-4 More than a few search terms cause facets to fail Major Closed
VUFIND-145 Create "public view" for advanced search queries. Major Resolved

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Greg Pendlebury added a comment -
Currently in trunk. Some work required to use on every screen.
Show
Greg Pendlebury added a comment - Currently in trunk. Some work required to use on every screen.
Hide
Permalink
Till Kinstler added a comment -
Seems at least one XSL sheet used in SearchObject.php is missing in the trunk: web/services/Search/xsl/json-rss.xsl
Show
Till Kinstler added a comment - Seems at least one XSL sheet used in SearchObject.php is missing in the trunk: web/services/Search/xsl/json-rss.xsl
Hide
Permalink
Demian Katz added a comment -
I've reopened VUFIND-114 -- we need to reconcile Andrew's new RSS code with the adapted old code found in the Search Object.
Show
Demian Katz added a comment - I've reopened VUFIND-114 -- we need to reconcile Andrew's new RSS code with the adapted old code found in the Search Object.
Hide
Permalink
Demian Katz added a comment -
The Search Object was implemented in time for RC2, but it was not fully integrated with every module of the code -- I'm leaving this issue open but pushing it forward to the 1.0 list, since its completion is not a prerequisite for releasing RC2 in a functional state.
Show
Demian Katz added a comment - The Search Object was implemented in time for RC2, but it was not fully integrated with every module of the code -- I'm leaving this issue open but pushing it forward to the 1.0 list, since its completion is not a prerequisite for releasing RC2 in a functional state.
Hide
Permalink
Demian Katz added a comment -
As of r2114, all of the search actions (standard, new items, reserves, authors, Summon, etc.) in the code are using the Search Object. The WorldCat module still needs to be refactored to use the Search Object logic, but that's a separate work in progress and shouldn't hold this ticket open. There are also some places where the Solr class is accessed directly; it's possible that these might be changed to use the Search Object instead, but that may or may not be appropriate. At this point, I'm comfortable with closing this ticket -- all the mature code that should use the full functionality of the Search Object (URL generation, GET parameter handling, etc.) is now taking advantage of it.
Show
Demian Katz added a comment - As of r2114, all of the search actions (standard, new items, reserves, authors, Summon, etc.) in the code are using the Search Object. The WorldCat module still needs to be refactored to use the Search Object logic, but that's a separate work in progress and shouldn't hold this ticket open. There are also some places where the Solr class is accessed directly; it's possible that these might be changed to use the Search Object instead, but that may or may not be appropriate. At this point, I'm comfortable with closing this ticket -- all the mature code that should use the full functionality of the Search Object (URL generation, GET parameter handling, etc.) is now taking advantage of it.

People

Vote (0)
Watch (0)

Dates

  • Created:
    Updated:
    Resolved:
Atlassian JIRA (v4.4.1#660-r161644) | Report a problem
Powered by a free Atlassian JIRA open source license for Villanova University. Try JIRA - bug tracking software for your team.