VuFind

Search History does not keep track of facets

Details

  • Type: Bug Bug
  • Status: Resolved Resolved
  • Priority: Major Major
  • Resolution: Fixed
  • Affects Version/s: 0.8.2
  • Fix Version/s: 1.0RC2
  • Component/s: Search
  • Labels:
    None

Description

When a user clicks on one of the facets, the search history grows by 1, however the "limit" is not displayed.

Issue Links

This issue is incorporated by:
VUFIND-134 Finish implementation of Search Object Major Resolved

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Eoghan Ó Carragáin added a comment -
A patch to fix issue with limits not appearing in search history. To get this to work all that was need was to replace the line "elseif ($urlArray[0] == 'format[]')" with "elseif ($urlArray[0] == 'filter[]')" in services/History.php.

However this patch also includes the following changes:
- services/History.php now replaces the facet field names (e.g. topic_facet) with the corresponding display form from facets.ini
- "format" renamed throughout to "filter" in php variables and smarty templates (default & classic themes)
Show
Eoghan Ó Carragáin added a comment - A patch to fix issue with limits not appearing in search history. To get this to work all that was need was to replace the line "elseif ($urlArray[0] == 'format[]')" with "elseif ($urlArray[0] == 'filter[]')" in services/History.php. However this patch also includes the following changes: - services/History.php now replaces the facet field names (e.g. topic_facet) with the corresponding display form from facets.ini - "format" renamed throughout to "filter" in php variables and smarty templates (default & classic themes)
Hide
Permalink
Eoghan Ó Carragáin added a comment -
There is still a minor problem with this. If you back and forth between the History page and search results page using the Browser's back button, the filters are duplicated in the display. Maybe not a very common use case, but it shouldn't happen, and I'm not sure why it is.

Any suggestions why this might be happening?
Show
Eoghan Ó Carragáin added a comment - There is still a minor problem with this. If you back and forth between the History page and search results page using the Browser's back button, the filters are duplicated in the display. Maybe not a very common use case, but it shouldn't happen, and I'm not sure why it is. Any suggestions why this might be happening?
Hide
Permalink
Greg Pendlebury added a comment -
I'm not sure how I assign tasks, but I can take this. It will be fixed in the new search object.
Show
Greg Pendlebury added a comment - I'm not sure how I assign tasks, but I can take this. It will be fixed in the new search object.
Hide
Permalink
Till Kinstler added a comment - - edited
This will be solved by implementation of SearchObject (VUFIND-134).
Show
Till Kinstler added a comment - - edited This will be solved by implementation of SearchObject (VUFIND-134).
Hide
Permalink
Greg Pendlebury added a comment -
SearchObject is currently in trunk and this works. VUFIND-134 will stay open until SearchObject is expanded to cover all screens.
Show
Greg Pendlebury added a comment - SearchObject is currently in trunk and this works. VUFIND-134 will stay open until SearchObject is expanded to cover all screens.

People

Vote (1)
Watch (1)

Dates

  • Created:
    Updated:
    Resolved:
Atlassian JIRA (v4.4.1#660-r161644) | Report a problem
Powered by a free Atlassian JIRA open source license for Villanova University. Try JIRA - bug tracking software for your team.