VuFind

RSS feed omits narrowing filters

Details

  • Type: Bug Bug
  • Status: Resolved Resolved
  • Priority: Major Major
  • Resolution: Fixed
  • Affects Version/s: 0.8.2
  • Fix Version/s: 1.0RC2
  • Component/s: Search
  • Labels:
    None

Description

The RSS feed option at the bottom of most results pages only captures
"lookfor=" parameter. If the user has used any narrowing options they are
ignored.

Issue Links

Activity

Hide
Eoghan Ó Carragáin added a comment -
Using the $fullPath variable which is already assigned to Search/list.tpl and appending &view=rss seems to give the desired result:

Old - bug:
<a href="{$url}/Search/{$action}?lookfor={$lookfor|escape}&type={$type}&view=rss" class="feed">{translate text='Get RSS Feed'}</a>

New - fixed(?):
<a href="{$fullPath}&view=rss" class="feed">{translate text='Get RSS Feed'}</a>
       
Show
Eoghan Ó Carragáin added a comment - Using the $fullPath variable which is already assigned to Search/list.tpl and appending &view=rss seems to give the desired result: Old - bug: <a href="{$url}/Search/{$action}?lookfor={$lookfor|escape}&type={$type}&view=rss" class="feed">{translate text='Get RSS Feed'}</a> New - fixed(?): <a href="{$fullPath}&view=rss" class="feed">{translate text='Get RSS Feed'}</a>        
Hide
Eoghan Ó Carragáin added a comment -
An alternative way that also works for me is:

Old - bug:
<a href="{$url}/Search/{$action}?lookfor={$lookfor|escape}&type={$type}&view=rss" class="feed">{translate text='Get RSS Feed'}</a>

New - fixed(?):
<a href="{$url}/Search/{$action}?lookfor={$lookfor|escape}&type={$type}{foreach from=$filterList item=filter}&filter[]={$filter.field|escape}:{$filter.value|escape}{/foreach}&view=rss" class="feed">{translate text='Get RSS Feed'}</a>
      

I can't get either solution to break using r1355, but I may not have tested everything. Any comments/feedback/improvements welcome. This may be redundant once RSS is refactored to deal with JSON post r1370.
Show
Eoghan Ó Carragáin added a comment - An alternative way that also works for me is: Old - bug: <a href="{$url}/Search/{$action}?lookfor={$lookfor|escape}&type={$type}&view=rss" class="feed">{translate text='Get RSS Feed'}</a> New - fixed(?): <a href="{$url}/Search/{$action}?lookfor={$lookfor|escape}&type={$type}{foreach from=$filterList item=filter}&filter[]={$filter.field|escape}:{$filter.value|escape}{/foreach}&view=rss" class="feed">{translate text='Get RSS Feed'}</a>        I can't get either solution to break using r1355, but I may not have tested everything. Any comments/feedback/improvements welcome. This may be redundant once RSS is refactored to deal with JSON post r1370.
Hide
Greg Pendlebury added a comment -
I'm not sure how I assign tasks, but I can take this. It will be fixed in the new search object.
Show
Greg Pendlebury added a comment - I'm not sure how I assign tasks, but I can take this. It will be fixed in the new search object.
Hide
Greg Pendlebury added a comment -
New SearchObject renders the links as well as the resultant RSS. Currently functional for normal searches. Moving this ticket to resolved. VUFIND-134 will remain open until SearchObject works for all search screens.
Show
Greg Pendlebury added a comment - New SearchObject renders the links as well as the resultant RSS. Currently functional for normal searches. Moving this ticket to resolved. VUFIND-134 will remain open until SearchObject works for all search screens.

People

Vote (1)
Watch (2)

Dates

  • Created:
    Updated:
    Resolved: