Uploaded image for project: 'VuFind'
  1. VuFind
  2. VUFIND-1128

facet_limit = -1 affects facet sorting

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 2.5
    • Fix Version/s: 3.0
    • Component/s: None
    • Labels:
      None

      Description

      I think I have found a bug in the facet settings: setting Results_Settings.facet_limit to -1 in facets.ini (to get unlimited facet values) sets facet sorting to index (alphabetical) order, not regarding sorted_by_index[] settings in the same configuration file.

        Activity

        Hide
        demiankatz Demian Katz added a comment -
        This wasn't exactly a bug, in the sense that it was the result of intentional logic. The Solr docs specify that unlimited facets get a different default sort behavior than limited facets (see https://wiki.apache.org/solr/SimpleFacetParameters#facet.sort). VuFind was mimicking this. However, now that we have the sorted_by_index[] setting, we always want to use count sorts unless told otherwise, so the default Solr behavior is really irrelevant. Thus, I've fixed the behavior here: https://github.com/vufind-org/vufind/commit/f2cb6278f03933bf9a3eb3695f58c9f834767e77

        Thanks for the catch! That was a weird one!
        Show
        demiankatz Demian Katz added a comment - This wasn't exactly a bug, in the sense that it was the result of intentional logic. The Solr docs specify that unlimited facets get a different default sort behavior than limited facets (see https://wiki.apache.org/solr/SimpleFacetParameters#facet.sort) . VuFind was mimicking this. However, now that we have the sorted_by_index[] setting, we always want to use count sorts unless told otherwise, so the default Solr behavior is really irrelevant. Thus, I've fixed the behavior here: https://github.com/vufind-org/vufind/commit/f2cb6278f03933bf9a3eb3695f58c9f834767e77 Thanks for the catch! That was a weird one!

          People

          • Assignee:
            Unassigned
            Reporter:
            olli Oliver Goldschmidt
          • Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: