VuFind
  1. VuFind
  2. VUFIND-268

Exercise VuFind under PHP 5.3.x

    Details

    • Type: Improvement Improvement
    • Status: Resolved
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 2.0alpha
    • Component/s: Tests
    • Labels:
      None

      Description

      Currently, VuFind is developed for the PHP 5.2.x line; we should test all code under PHP 5.3.x to see if any deprecation warnings need to be addressed or if other problems exist.

      As of this writing, at least two PEAR modules cause some deprecation warnings (HTTP_Request and XML_Unserializer). Perhaps these problems will be addressed over time at the PEAR end, but we might want to consider migrating from HTTP_Request to HTTP_Request2 and/or replacing reliance on XML_Unserializer with PHP's built-in SimpleXML functionality.

        Activity

        Hide
        Demian Katz added a comment -
        We reduced reliance on the XML_Unserializer in r2967 and r2970. However, it is still used in a few places and it would be nice to further eliminate dependencies on it. Additionally, the module may be getting included in some places where it doesn't need to be -- some analysis and refactoring of this situation would be worthwhile.
        Show
        Demian Katz added a comment - We reduced reliance on the XML_Unserializer in r2967 and r2970. However, it is still used in a few places and it would be nice to further eliminate dependencies on it. Additionally, the module may be getting included in some places where it doesn't need to be -- some analysis and refactoring of this situation would be worthwhile.
        Hide
        Demian Katz added a comment -
        As of v0.20.1, the PHP warnings related to XML_Unserializer have been fixed in the PEAR library -- run "pear upgrade XML_Serializer" to update your server to the latest version. The HTTP_Request problems are unchanged as of this writing, though -- still probably worth investigating an upgrade to HTTP_Request2 when time permits.
        Show
        Demian Katz added a comment - As of v0.20.1, the PHP warnings related to XML_Unserializer have been fixed in the PEAR library -- run "pear upgrade XML_Serializer" to update your server to the latest version. The HTTP_Request problems are unchanged as of this writing, though -- still probably worth investigating an upgrade to HTTP_Request2 when time permits.
        Hide
        Ted Lawless added a comment -

        We are seeing the following message in Apache error logs for our production instance running PHP 5.3.0 under Red Hat.

        "Deprecated: Assigning the return value of new by reference is deprecated in /usr/share/php/XML/Parser.php on line 616"

        The pear XML_Parser is up-to-date at 1.3.4. I did see this forum post on a patch to Parser.php to suppress the errors. It removed the errors in development but I'm not sure if it's a good idea to change the XML_Parser library core like this.

        http://forums.gplhost.com/phpBB2/image-vp13389.html
        Show
        Ted Lawless added a comment - We are seeing the following message in Apache error logs for our production instance running PHP 5.3.0 under Red Hat. "Deprecated: Assigning the return value of new by reference is deprecated in /usr/share/php/XML/Parser.php on line 616" The pear XML_Parser is up-to-date at 1.3.4. I did see this forum post on a patch to Parser.php to suppress the errors. It removed the errors in development but I'm not sure if it's a good idea to change the XML_Parser library core like this. http://forums.gplhost.com/phpBB2/image-vp13389.html
        Hide
        Demian Katz added a comment -
        Looks like that patch should be harmless, though obviously patching the library core isn't ideal if other options exist -- in this case, though, I think it's the best you can do. Starting with VuFind 2.0, we're going to move away from using so many PEAR libraries, so hopefully problems of this nature will be less frequent.
        Show
        Demian Katz added a comment - Looks like that patch should be harmless, though obviously patching the library core isn't ideal if other options exist -- in this case, though, I think it's the best you can do. Starting with VuFind 2.0, we're going to move away from using so many PEAR libraries, so hopefully problems of this nature will be less frequent.
        Hide
        Demian Katz added a comment -
        This problem will go away with VuFind 2.0; the 2.0 codebase is being developed under PHP 5.3 and does not rely on any deprecated PEAR libraries.
        Show
        Demian Katz added a comment - This problem will go away with VuFind 2.0; the 2.0 codebase is being developed under PHP 5.3 and does not rely on any deprecated PEAR libraries.

          People

          • Assignee:
            Unassigned
            Reporter:
            Demian Katz
          • Votes:
            1 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: