VuFind
  1. VuFind
  2. VUFIND-625

Add to Favorites and Shibboleth authentication

    Details

    • Type: Improvement Improvement
    • Status: Resolved
    • Priority: Trivial Trivial
    • Resolution: Fixed
    • Affects Version/s: 1.3
    • Fix Version/s: 2.0beta
    • Component/s: None
    • Labels:
      None

      Description

      Clicking to Add to Favorites should directly redirect the user to Shibboleth if Shibboleth authentication is enabled (see the attached patch for web/services/Record/Save.php).
      1. Interface.php.patch
        2 kB
        Vaclav Rosecky
      2. Save.php.patch
        1 kB
        Vaclav Rosecky

        Activity

        Hide
        Vaclav Rosecky added a comment -
        Patch for web/sys/Interface.php
        Show
        Vaclav Rosecky added a comment - Patch for web/sys/Interface.php
        Hide
        Demian Katz added a comment -
        VuFind 2 handles this situation better than VuFind 1. However, we display an "institutional login" link rather than pushing the user directly into Shibboleth. This allows display of status messages if there is a problem (as opposed to an infinite redirect loop) and it also avoids the need for custom lightbox functionality to forward correctly. If somebody comes up with a more elegant way to avoid the extra click in 2.0, please open a new ticket with a patch. For now, I'm going to treat this ticket as resolved in 2.0; I don't think I'm going to find time to test and merge this patch in the 1.x code before that code base is deprecated. If somebody needs the functionality in 1.x, at least we have these patches available (though I think they need a little tweaking to be universally compatible -- there seem to be some institution-specific assumptions here).
        Show
        Demian Katz added a comment - VuFind 2 handles this situation better than VuFind 1. However, we display an "institutional login" link rather than pushing the user directly into Shibboleth. This allows display of status messages if there is a problem (as opposed to an infinite redirect loop) and it also avoids the need for custom lightbox functionality to forward correctly. If somebody comes up with a more elegant way to avoid the extra click in 2.0, please open a new ticket with a patch. For now, I'm going to treat this ticket as resolved in 2.0; I don't think I'm going to find time to test and merge this patch in the 1.x code before that code base is deprecated. If somebody needs the functionality in 1.x, at least we have these patches available (though I think they need a little tweaking to be universally compatible -- there seem to be some institution-specific assumptions here).

          People

          • Assignee:
            Demian Katz
            Reporter:
            Vaclav Rosecky
          • Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: