VuFind
  1. VuFind
  2. VUFIND-840

Move creation of SOLR spelling query to SOLR query builder

    Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 2.0.1
    • Fix Version/s: 2.2
    • Component/s: Search
    • Labels:
      None

      Description

      It makes sense to delegate creation of the spelling query to the SOLR QueryBuilder. This would also clean up Results/Params where this is currently done.

      We need:
        a. the algorithm to translate a Query and/or QueryGroup into a spelling query
        b. a method QueryBuilder::setCreateSpellingQuery()
        c. a place where we decide whether to build a spelling query or not

      c) If spellcheck is only controlled by configuration we can simply enable/disable the process in the factory. Otherwise we could move towards a 'SearchParameterProvider'-Setup and delegate this configuration step to a Listener, like we do for the hl-configuration.

        Activity

        Hide
        Demian Katz added a comment -
        Show
        Demian Katz added a comment - Implemented here: https://github.com/vufind-org/vufind/pull/25
        Hide
        David Maus added a comment -
        Merged pull request
        Show
        David Maus added a comment - Merged pull request

          People

          • Assignee:
            Demian Katz
            Reporter:
            David Maus
          • Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: