VuFind
  1. VuFind
  2. VUFIND-862

Some "related record" ISN links fail

    Details

    • Type: Bug Bug
    • Status: Resolved
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 2.0, 2.0.1
    • Fix Version/s: 2.1
    • Component/s: Record, Search
    • Labels:
      None

      Description

      When the "record links" setting (which connects records based on MARC 7xx fields) is enabled, ISBN links can fail if the ISBNs contain notes with a trailing colon. By adjusting the links to put double quotes around the ISBN, this problem can be avoided -- see attached patch.

        Activity

        Show
        Demian Katz added a comment - Patch committed here: https://github.com/vufind-org/vufind/commit/2b5443947047fef0ffe809c5b119b4d6b7c2caf0
        Hide
        Jay Roos added a comment -
        The patch works, but it got me thinking. Is there a proper way to escape the colon for SOLR? Maybe that would be a better fix?
        Show
        Jay Roos added a comment - The patch works, but it got me thinking. Is there a proper way to escape the colon for SOLR? Maybe that would be a better fix?
        Hide
        Demian Katz added a comment -
        You can escape the colon with a backslash, but I think in this case, doing a phrase search is actually the better fix because it ensures a more exact match -- assuming no metadata errors, we want the linking field and the ISBN field to contain exactly the same values in exactly the same order, so using a phrase makes sense.
        Show
        Demian Katz added a comment - You can escape the colon with a backslash, but I think in this case, doing a phrase search is actually the better fix because it ensures a more exact match -- assuming no metadata errors, we want the linking field and the ISBN field to contain exactly the same values in exactly the same order, so using a phrase makes sense.

          People

          • Assignee:
            Unassigned
            Reporter:
            Demian Katz
          • Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: