[VUFIND-1128] facet_limit = -1 affects facet sorting Created: 16/Oct/15 Updated: 16/Oct/15 Resolved: 16/Oct/15 |
|
| Status: | Resolved |
| Project: | VuFind® |
| Components: | None |
| Affects versions: | 2.5 |
| Fix versions: | 3.0 |
| Type: | Bug | Priority: | Minor |
| Reporter: | Oliver Goldschmidt | Assignee: | Unassigned |
| Resolution: | Fixed | Votes: | 0 |
| Labels: | None | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original estimate: | Not Specified | ||
| Description |
|
I think I have found a bug in the facet settings: setting Results_Settings.facet_limit to -1 in facets.ini (to get unlimited facet values) sets facet sorting to index (alphabetical) order, not regarding sorted_by_index[] settings in the same configuration file.
|
| Comments |
| Comment by Demian Katz [ 16/Oct/15 ] |
|
This wasn't exactly a bug, in the sense that it was the result of intentional logic. The Solr docs specify that unlimited facets get a different default sort behavior than limited facets (see https://wiki.apache.org/solr/SimpleFacetParameters#facet.sort). VuFind was mimicking this. However, now that we have the sorted_by_index[] setting, we always want to use count sorts unless told otherwise, so the default Solr behavior is really irrelevant. Thus, I've fixed the behavior here: https://github.com/vufind-org/vufind/commit/f2cb6278f03933bf9a3eb3695f58c9f834767e77 Thanks for the catch! That was a weird one! |