[VUFIND-1291] List edit/delete glitches Created: 19/Jul/18 Updated: 26/Jul/18 Resolved: 26/Jul/18 |
|
| Status: | Resolved |
| Project: | VuFind® |
| Components: | MyResearch |
| Affects versions: | 5.0 |
| Fix versions: | 5.0.1 |
| Type: | Bug | Priority: | Minor |
| Reporter: | Demian Katz | Assignee: | Chris Hallberg |
| Resolution: | Fixed | Votes: | 0 |
| Labels: | None | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original estimate: | Not Specified | ||
| Description |
|
I just noticed some undesirable behaviors in the list editing functionality. Problem #1. 1.) Add an item to a list. 2.) Go to the list. 3.) Click the edit button next to the item you added. 4.) Click the delete button at the bottom of the edit screen. 5.) Click "no" in the pop-up. You now have a garbled display. This is a pretty obvious problem that hopefully has a straightforward solution. Problem #2: 1.) From the same edit screen you were viewing in step 4 above, click the "delete" button again, but this time, select "yes." 2.) Acknowledge the pop-up by clicking "close." 3.) You are now on a screen that says "The record you selected is not part of any of your lists." and has a save button at the bottom. 4.) Click "save." 5.) You now get a "list successfully updated" acknowledgement, but nothing has been added to your list. This is more subtle -- this is happening because the "add to another list" drop-down is not being set to a specific list. I'm not sure that this is exactly a bug, but it's certainly counterintuitive behavior that could confuse users. At very least, perhaps if there is no data to edit on the screen, and the user hasn't selected a valid list, hitting "save" should result in an error message instead of a success message. When this is all fixed, we should probably add a Mink test suite to cover this functionality, as I don't believe it is currently being tested (or if it is being tested, it's not being THOROUGHLY tested). |
| Comments |
| Comment by Chris Hallberg [ 20/Jul/18 ] |
|
I solved the first bug but didn't get the same result for the second: http://prntscr.com/k9058a Once that's sorted, tests do sound like a good plan. |
| Comment by Demian Katz [ 26/Jul/18 ] |
| These bugs have been fixed, so I am closing the ticket. Adding test suite coverage is still worth doing, though! |