Interface.php.patch
Save.php.patch
[VUFIND-625] Add to Favorites and Shibboleth authentication Created: 12/Jul/12 Updated: 24/Oct/12 Resolved: 24/Oct/12 |
|
| Status: | Resolved |
| Project: | VuFind® |
| Components: | None |
| Affects versions: | 1.3 |
| Fix versions: | 2.0beta |
| Type: | Improvement | Priority: | Trivial |
| Reporter: | Václav Rosecký | Assignee: | Demian Katz |
| Resolution: | Fixed | Votes: | 0 |
| Labels: | None | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original estimate: | Not Specified | ||
| Attachments: |
Interface.php.patch
Save.php.patch
|
| Description |
|
Clicking to Add to Favorites should directly redirect the user to Shibboleth if Shibboleth authentication is enabled (see the attached patch for web/services/Record/Save.php).
|
| Comments |
| Comment by Václav Rosecký [ 10/Aug/12 ] |
| Patch for web/sys/Interface.php |
| Comment by Demian Katz [ 24/Oct/12 ] |
| VuFind 2 handles this situation better than VuFind 1. However, we display an "institutional login" link rather than pushing the user directly into Shibboleth. This allows display of status messages if there is a problem (as opposed to an infinite redirect loop) and it also avoids the need for custom lightbox functionality to forward correctly. If somebody comes up with a more elegant way to avoid the extra click in 2.0, please open a new ticket with a patch. For now, I'm going to treat this ticket as resolved in 2.0; I don't think I'm going to find time to test and merge this patch in the 1.x code before that code base is deprecated. If somebody needs the functionality in 1.x, at least we have these patches available (though I think they need a little tweaking to be universally compatible -- there seem to be some institution-specific assumptions here). |