[VUFIND-840] Move creation of SOLR spelling query to SOLR query builder Created: 08/Jul/13  Updated: 30/Aug/13  Resolved: 30/Aug/13

Status: Closed
Project: VuFind®
Components: Search
Affects versions: 2.0.1
Fix versions: 2.2

Type: Improvement Priority: Major
Reporter: David Maus Assignee: Demian Katz
Resolution: Fixed Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original estimate: Not Specified


 Description   
It makes sense to delegate creation of the spelling query to the SOLR QueryBuilder. This would also clean up Results/Params where this is currently done.

We need:
  a. the algorithm to translate a Query and/or QueryGroup into a spelling query
  b. a method QueryBuilder::setCreateSpellingQuery()
  c. a place where we decide whether to build a spelling query or not

c) If spellcheck is only controlled by configuration we can simply enable/disable the process in the factory. Otherwise we could move towards a 'SearchParameterProvider'-Setup and delegate this configuration step to a Listener, like we do for the hl-configuration.


 Comments   
Comment by Demian Katz [ 29/Aug/13 ]
Implemented here:

https://github.com/vufind-org/vufind/pull/25
Comment by David Maus [ 30/Aug/13 ]
Merged pull request
Generated at Tue Mar 19 08:06:21 UTC 2024 using Jira 1001.0.0-SNAPSHOT#100247-rev:89f7b815443a08d35b56351a3b54c9592fbc4cf9.