[VUFIND-862] Some "related record" ISN links fail Created: 26/Jul/13  Updated: 30/Jul/13  Resolved: 30/Jul/13

Status: Resolved
Project: VuFind
Component/s: Record, Search
Affects Version/s: 2.0, 2.0.1
Fix Version/s: 2.1

Type: Bug Priority: Minor
Reporter: Demian Katz Assignee: Unassigned
Resolution: Fixed Votes: 0
Labels: None

Attachments: Text File linkfix.patch    

 Description   
When the "record links" setting (which connects records based on MARC 7xx fields) is enabled, ISBN links can fail if the ISBNs contain notes with a trailing colon. By adjusting the links to put double quotes around the ISBN, this problem can be avoided -- see attached patch.

 Comments   
Comment by Demian Katz [ 30/Jul/13 ]
Patch committed here:

https://github.com/vufind-org/vufind/commit/2b5443947047fef0ffe809c5b119b4d6b7c2caf0
Comment by Jay Roos [ 30/Jul/13 ]
The patch works, but it got me thinking. Is there a proper way to escape the colon for SOLR? Maybe that would be a better fix?
Comment by Demian Katz [ 30/Jul/13 ]
You can escape the colon with a backslash, but I think in this case, doing a phrase search is actually the better fix because it ensures a more exact match -- assuming no metadata errors, we want the linking field and the ISBN field to contain exactly the same values in exactly the same order, so using a phrase makes sense.
Generated at Wed Dec 13 02:13:30 EST 2017 using JIRA 6.2.6#6264-sha1:ee7642271310c09537d01e5848a003c4498a0eed.