[VUFIND-1263] Broken hierarchy features Created: 03/Jan/18 Updated: 17/Jan/18 Resolved: 17/Jan/18 |
|
Status: | Resolved |
Project: | VuFind® |
Components: | Hierarchy |
Affects versions: | 4.1, 4.1.1 |
Fix versions: | 4.1.2 |
Type: | Bug | Priority: | Major |
Reporter: | Demian Katz | Assignee: | Chris Hallberg |
Resolution: | Fixed | Votes: | 0 |
Labels: | None | ||
Remaining Estimate: | Not Specified | ||
Time Spent: | Not Specified | ||
Original estimate: | Not Specified |
Description |
Refactoring of code in release 4.1 (or possibly earlier, in some cases) broke some hierarchy-related features and displays. Problems include: - Long titles overflow the lightbox in the hierarchy instead of wrapping - The right preview pane of the hierarchy view displays in the lightbox, where it is supposed to be suppressed; it should only show up in the context tab - When the right preview pane is present and the hierarchy is very long, the user must scroll down so far that they do not see the preview when they click on items (this is a long pre-existing problem, noticed during testing of other issues) - The fullHierarchyRecordView setting no longer has any effect - Scrolling to the selected record in the hierarchy does not always work correctly in the lightbox |
Comments |
Comment by Demian Katz [ 03/Jan/18 ] |
Some fixes for issues listed above: https://github.com/vufind-org/vufind/commit/2959c9ebeb4cd0e6332d7e0b60f1f9d9364e4718 (fix wrapping) https://github.com/vufind-org/vufind/commit/d51c1cd5f75caa888a31be98b0c4dd671ba094e7 (fix preview in lightbox) https://github.com/vufind-org/vufind/commit/458ba7077d834ab762994ba45601ade1212a53df (fix "long hierarchy hides preview" problem) The commit at https://github.com/vufind-org/vufind/commit/a452df84c862e71fe6dd6edb4549975ec6f32e78 is also significant, as it reveals the problem with the broken fullHierarchyRecordView setting by removing orphaned code. |
Comment by Chris Hallberg [ 16/Jan/18 ] |
I just tested all of the issues and I think the commits above account for all of them. |