====== VuFind® Community Call Minutes: May 7, 2024 ====== Attending: Chris Hallberg, Demian Katz, Maccabee Levine, Luke Magayo, Peter Murray, Mario Trojan, Susan Turkel, Thomas Wagener Apologies: Ere Maijala ===== Agenda ===== ==== 1. Development Planning ==== === Newsletter Highlights === The [[community:newsletter:2024-04|April, 2024]] Newsletter was discussed. === Pull Request / Ticket Review (release 9.1.2) === * [[https://github.com/vufind-org/vufind/pull/3557|#3557]] - Fix bug: incorrect author link hidden filter in combined search * Status: We need to determine if this can be fixed in 9.1.2 or needs to be delayed. * :!: ACTION ITEM: Demian and Ere should discuss * [[https://github.com/vufind-org/vufind/pull/3576|#3576]] - Aleph driver: improve ID and date processing * Status: Needs review. * :!: ACTION ITEM: please review! * [[https://github.com/vufind-org/vufind/pull/3635|#3635]] - Initialize head theme resources in combined AJAX responses * Status: Needs review. * :!: ACTION ITEM: please review! === Pull Request Review (release 10.0) === The following pull requests are scheduled for inclusion in release 10: == Architectural Enhancements == * [[https://github.com/vufind-org/vufind/pull/1680|#1680]] - Display flash message on login * Status: Chris is working on this; we'll determine whether this can be completed in time for 10 based on how the next draft turns out. * :!: ACTION ITEM: Chris should determine next steps. * [[https://github.com/vufind-org/vufind/pull/2624|#2624]] / [[https://openlibraryfoundation.atlassian.net/browse/VUFIND-1514|VUFIND-1514]] - Replace grunt with NPM scripts * Status: Ere thinks we should defer this to 11.0 due to the complexity of the remaining work; it will be easier after bootstrap3 is removed. * :!: ACTION ITEM: Change milestone. * [[https://github.com/vufind-org/vufind/pull/2723|#2723]] - Component: confirmation menu * Status: this is at the top of Chris' list. * :!: ACTION ITEM: Chris should try to fix failing tests. * [[https://github.com/vufind-org/vufind/pull/2814|#2814]] - Replace jumpMenu controls with menu-button components * Status: this is at the top of Chris' list. * :!: ACTION ITEM: Chris should look at style/accessibility improvements and fix test failures * [[https://github.com/vufind-org/vufind/pull/2934|#2934]] - Switch to Splide Carousel Library * Status: Some behavior issues were fixed recently; minor style updates underway. * :!: ACTION ITEM: Chris will continue work; others should test/review. * [[https://github.com/vufind-org/vufind/pull/3222|#3222]] - Add bootstrap5 theme * Status: In progress * :!: ACTION ITEM: Ere should continue work; others should test as time permits. == New Features == * [[https://github.com/vufind-org/vufind/pull/3103|#3103]] - Add Notifications CMS functionality * Status: Currently in review; likely to get deferred to 10.1. * :!: ACTION ITEM: Johannes should continue working on review comments. * [[https://github.com/vufind-org/vufind/pull/3226|#3226]] - Adding the option to make html elements sticky * Status: In review * :!: ACTION ITEM: Chris should review the latest changes. * [[https://github.com/vufind-org/vufind/pull/3634|#3634]] / [[https://openlibraryfoundation.atlassian.net/browse/VUFIND-1653|VUFIND-1653]] - Allow schema.org metadata to be disabled via config * Status: In review * :!: ACTION ITEM: Review, please! * [[https://github.com/vufind-org/vufind/pull/3637|#3637]] - Add support for rate limiting * Status: This new feature was introduced in response to widespread problems with abusive crawling; even though it is new, we should aim to get it into the release to support users facing these challenges. (Mario mentioned that his team is evaluating mod_security; he's also looking at using change_tracker data to include more accurate history data in sitemaps). * :!: ACTION ITEM: Demian and Ere will work through the review process; input from others would be appreciated. == Smaller Features/Enhancements/Fixes == * [[https://github.com/vufind-org/vufind/pull/3279|#3279]] - Small enhancements to the DefaultRecord class * Status: In review. * :!: ACTION ITEM: Waiting for progress from @dmj. Demian has requested a status update. * [[https://github.com/vufind-org/vufind/pull/3494|#3494]] - Remove redundant language codes; use aliases * Status: In review * :!: ACTION ITEM: Waiting for progress from @sturkel89 * [[https://github.com/vufind-org/vufind/pull/3633|#3633]] - Fix bug: tag links not displaying in favorites * Status: Needs review * :!: ACTION ITEM: please review * [[https://github.com/vufind-org/vufind/pull/3640|#3640]] / [[https://openlibraryfoundation.atlassian.net/browse/VUFIND-1670|VUFIND-1670]] - Accessibility: use heading on spelling suggestions * Status: In review * :!: ACTION ITEM: Demian will act on Maccabee's feedback == Specialized PRs Requiring Input from Creators == * [[https://github.com/vufind-org/vufind/pull/2688|#2688]] - Announce number of search results in title * Status: Under discussion; will likely get postponed to a future release unless more input is received. * :!: ACTION ITEM: move to 10.1 milestone due to inactivity * [[https://github.com/vufind-org/vufind/pull/2763|#2763]] - SetupThemeResources: Ensure 'Content-Type' is never escaped * Status: On hold awaiting more input from the Google Scholar team * :!: ACTION ITEM: @mtrojan-ub will close * [[https://github.com/vufind-org/vufind/pull/2850|#2850]] - Change route type for Help/Home from Static to Segment * Status: Under discussion. * :!: ACTION ITEM: Demian will move to 10.1 milestone; not urgent. * [[https://github.com/vufind-org/vufind/pull/2999|#2999]] - Get unique html element id from record view helper * Status: In progress. * :!: ACTION ITEM: @robertlange81 should continue work (expected to happen this week) === Scheduled JIRA Tickets (release 10.0) === == Architectural Enhancements == * [[https://openlibraryfoundation.atlassian.net/browse/VUFIND-1614|VUFIND-1614]] - Modernize PubDateVisAjax recommendation module * Status: no progress yet * :!: ACTION ITEM: move to 10.1 milestone == Smaller Fixes/Improvements == * [[https://openlibraryfoundation.atlassian.net/browse/VUFIND-1521|VUFIND-1521]] - Add id validation to ILL requests and storage retrieval requests * Status: Demian reviewed this and couldn't find any missing functionality. * :!: ACTION ITEM: Ere should review Demian's comment on the ticket and either close the ticket or clarify the need. * [[https://openlibraryfoundation.atlassian.net/browse/VUFIND-1607|VUFIND-1607]] - Embedded records (in results list) have invalid aria and/or role attributes * Status: This is an unavoidable problem in Bootstrap 3; we should investigate whether Bootstrap 5 improves the situation. * :!: ACTION ITEM: check Bootstrap 5 situation; decide on next steps * [[https://openlibraryfoundation.atlassian.net/browse/VUFIND-1651|VUFIND-1651]] - Address Java deprecation of finalize() method in UpdateDateTracker.java * Status: Maccabee and Demian will look into if/when time permits. * [[https://openlibraryfoundation.atlassian.net/browse/VUFIND-1667|VUFIND-1667]] - Modal close button doesn't want to let focus go * Status: Chris should investigate. * [[https://openlibraryfoundation.atlassian.net/browse/VUFIND-1668|VUFIND-1668]] - Moravian Library Accessibility Report (Progress Tracking) * Status: Most of this is done, but we should figure out how to complete or reassign the remaining parts. == Test Suite Improvements == * [[https://openlibraryfoundation.atlassian.net/browse/VUFIND-1351|VUFIND-1351]] - Create Mink tests for email verification functionality * [[https://openlibraryfoundation.atlassian.net/browse/VUFIND-1560|VUFIND-1560]] - DeduplicationListener: Add tests and clean up == Documentation Tasks == * [[https://openlibraryfoundation.atlassian.net/browse/VUFIND-1625|VUFIND-1625]] - Document access to advanced search capabilities through API * [[https://openlibraryfoundation.atlassian.net/browse/VUFIND-1629|VUFIND-1629]] - Investigate changes in OpenAPI 3.1; implement for API if appropriate. == Finishing Touches (Tasks for Near Release Time) == * [[https://openlibraryfoundation.atlassian.net/browse/VUFIND-1645|VUFIND-1645]] - Update dependencies for release 10.0 * Status: this was done recently, but we will double-check closer to the release date. * [[https://openlibraryfoundation.atlassian.net/browse/VUFIND-1659|VUFIND-1659]] - Update GitHub branch protection rules when creating release-10.0 branch * Status: will do after releasing 9.1.2 * :!: ACTION ITEM: set release date for 9.1.2 first * [[https://openlibraryfoundation.atlassian.net/browse/VUFIND-1649|VUFIND-1649]] - Update language translation files for release 10.0 * Status: will begin about a month before the release date. * :!: ACTION ITEM: Demian will begin this process on May 20th. ==== 2. Technical Discussion: Theme Development Next Steps / Collaboration ==== Ere believes that the Bootstrap5 theme is nearly done. Some accessibility testing is still required, but he believes that it will be more accessible than the bootstrap3 theme even as it is. He has written a [[development:architecture:user_interface:bootstrap5|bootstrap5 wiki page]] to document some of the changes. We should be able to merge it soon; please continue testing as time permits. As noted above, Ere suggested deferring the replacement of Grunt scripts with NPM scripts until 11.0, since rewriting the current scripts required by bootstrap3 will be difficult, and some will no longer be needed once bootstrap3 is removed. We should also document the theme transition plan in the changelog: beta bootstrap5 in 10.0, mature bootstrap5 and deprecated bootstrap3 in 10.1, removal of bootstrap3 in 11.0. Susan raised the question of how sandal vs. sandal5 naming will be addressed during transition; we still need to work out some details there. Right now, the sandal5 theme exists to enable parallel testing of the bootstrap3-based sandal and the bootstrap5-based sandal5. When we get to 10.1, we may need to change the default to sandal5. The question then becomes, do we rename sandal5 to sandal in 11.0, or keep the numbered name? Is there another way forward? We should discuss as things continue to evolve. ==== 3. Technical Discussion: Database Code Migration Strategy ==== Demian has made significant progress on introducing database services and entity interfaces, but there is more to do. Any help, particularly with review so that work does not stall, would be greatly appreciated. ==== 4. Future of Slack ==== No updates yet from the OLF side; it's taking time to "de-FOLIO" the Slack to make it more suitable for shared use. It's hard to get the momentum to prefix all the names of the existing channels (e.g. change #support to #folio_support, etc., etc.). There's also a need to move the automatic signup system from FOLIO-land to OLF-land. We discussed the possibility of moving VuFind® in before completing the FOLIO renaming, but the auto signup migration is the bare minimum. Peter will work on that part this week, and then we can start working to transition. ==== 5. Open Q&A / Other Topics? ==== None this month. ===== Next Call ===== The next call will be Tuesday, June 4, 2024 at 9am Eastern Daylight Time (13:00 GMT).