Differences

This shows you the differences between two versions of the page.

--- community_call:minutes20230110 [2023/01/03 20:16] – created demiankatz
+++ community_call:minutes20230110 [2023/01/10 14:24] – [2. Technology Demo: Typescript Annotations] demiankatz
@@ Line 1: / Line 1: @@
 ====== VuFind® Community Call Minutes: January 10, 2023 ======
-Attending:
+Attending: Chris Hallberg, Demian Katz, Sudharma Kellampalli, Ere Maijala, Mario Trojan, Susan Turkel
 ===== Agenda =====
@@ Line 13: / Line 13: @@
 === Pull Request Review (9.0 milestone) ===
-  * [[https://github.com/vufind-org/vufind/pull/2400|#2400]] / [[https://openlibraryfoundation.atlassian.net/browse/VUFIND-1533|VUFIND-1533]] - Wrapped link elements should not have space between the lines [in progress]
+  * [[https://github.com/vufind-org/vufind/pull/2400|#2400]] / [[https://openlibraryfoundation.atlassian.net/browse/VUFIND-1533|VUFIND-1533]] - Wrapped link elements should not have space between the lines
     * Next step: resolve conflicts; finish testing and fixing outstanding issues - CH / DK
-  * [[https://github.com/vufind-org/vufind/pull/2447|#2447]] - AJAX status standardization/modernization [in progress]
+  * [[https://github.com/vufind-org/vufind/pull/2447|#2447]] - AJAX status standardization/modernization
     * Next step: final test/review - DK
-  * [[https://github.com/vufind-org/vufind/pull/2492|#2492]] - Add refresh buttons to jump menu controls [waiting on #2378]
+  * [[https://github.com/vufind-org/vufind/pull/2492|#2492]] - Add refresh buttons to jump menu controls
     * Next step: decide when to add buttons and when to use MenuButton controls from [[https://github.com/vufind-org/vufind/pull/2378|#2378]]
-  * [[https://github.com/vufind-org/vufind/pull/2543|#2543]] - ThemeInfo: Fix getMergedConfig [in progress]
+  * [[https://github.com/vufind-org/vufind/pull/2543|#2543]] - ThemeInfo: Fix getMergedConfig
     * Next steps: finish discussion, ensure full test coverage - CH / DK
-  * [[https://github.com/vufind-org/vufind/pull/2580|#2580]] / [[https://openlibraryfoundation.atlassian.net/browse/VUFIND-1573|VUFIND-1573]] - Upgrade Solr for release 9.0 [Solr 9 major upgrade complete but not yet merged]
+  * [[https://github.com/vufind-org/vufind/pull/2624|#2624]] / [[https://openlibraryfoundation.atlassian.net/browse/VUFIND-1514|VUFIND-1514]] - Modernize front end build environment, replace Grunt with NPM scripts
-    * Next step: decide whether Solr 9 belongs in release 9.0 or 10.0 of VuFind® -- no strong opinions on call; DK will talk EM
-  * [[https://github.com/vufind-org/vufind/pull/2624|#2624]] / [[https://openlibraryfoundation.atlassian.net/browse/VUFIND-1514|VUFIND-1514]] - Modernize front end build environment, replace Grunt with NPM scripts [in progress]
     * Next step: Discuss / finish TODO list - CH
-  * [[https://github.com/vufind-org/vufind/pull/2640|#2640]] / [[https://openlibraryfoundation.atlassian.net/browse/VUFIND-1563|VUFIND-1563]] - Blowfish encryption fails under Ubuntu 22 and Fedora 36 [in progress]
+  * [[https://github.com/vufind-org/vufind/pull/2640|#2640]] / [[https://openlibraryfoundation.atlassian.net/browse/VUFIND-1563|VUFIND-1563]] - Blowfish encryption fails under Ubuntu 22 and Fedora 36
     * Next step: continue test/review process - CH / DK
   * [[https://github.com/vufind-org/vufind/pull/2660|#2660]] / [[https://openlibraryfoundation.atlassian.net/browse/VUFIND-1529|VUFIND-1529]] - Configurable sort tie-breaker field
     * Next step: continue test/review process - SK / DK
+  * [[https://github.com/vufind-org/vufind/pull/2668|#2668]] - Avoid null pointer exception in getSubfieldOrDefault
+    * Next step: final testing - DK
 === JIRA Ticket Review (9.0 release, without an existing pull request above) ===
@@ Line 46: / Line 46: @@
     * Prerequisite: complete all changes that impact language files.
-==== 2. Technology Demo ====
+==== 2. Technology Demo: Typescript Annotations ====
+Chris mentioned that after reflecting on feedback from last month's discussion, he opened a [[https://openlibraryfoundation.atlassian.net/browse/VUFIND-1590|JIRA ticket]] with a proposed solution to the variable management challenge he previously discussed.
+Chris then demonstrated a way to add [[https://www.typescriptlang.org/docs/handbook/jsdoc-supported-types.html|JSDoc comments]] to Javascript to apply Typescript types without requiring a compilation step -- this allows VuFind to potentially benefit from Typescript documentation and validation tools without having to change our build process or make the addition/changing of Javascript code more complicated.
+It should be easy to integrate type checking into continuous integration. It should also be possible to enforce the inclusion of typing via eslint with "no-implicit-any".
+We should be able to introduce this via a new pull request; no need to wait on other "npm scripts" work in progress before we begin. Chris suggested finishing up the AJAX modernization before introducing this to avoid duplication of effort.
+There was discussion of whether we should at some point introduce a compilation step for our Javascript assets. Down sides: introducing compilation steepens learning curve; could complicate deployment process for complex sites like Finna with many views. Advantage: would make it easier to manage dependencies, and to include libraries that don't necessarily have an easy-to-include, stand-alone .js version.
+Possible middle ground on compilation: a compiled.js which lumps together third-party dependencies, without making it impossible to override VuFind-specific .js code. This could follow the precedent of compiled.css and offer some benefits without all the drawbacks.
 ==== 3. Open Q&A / Other Topics? ====