Warning: This page has not been updated in over over a year and may be outdated or deprecated.
community_call:minutes20231107
Differences
This shows you the differences between two versions of the page.
Both sides previous revisionPrevious revisionNext revision | Previous revision | ||
community_call:minutes20231107 [2023/11/02 16:04] – [1. Development Planning] sturkel | community_call:minutes20231107 [2023/11/07 15:59] (current) – [2. Technical Discussion: Theme Development Next Steps / Collaboration] demiankatz | ||
---|---|---|---|
Line 1: | Line 1: | ||
====== VuFind® Community Call Minutes: November 7, 2023 ====== | ====== VuFind® Community Call Minutes: November 7, 2023 ====== | ||
- | Attending: | + | Attending: |
===== Agenda ===== | ===== Agenda ===== | ||
Line 14: | Line 14: | ||
The following pull requests are scheduled for inclusion in release 10: | The following pull requests are scheduled for inclusion in release 10: | ||
+ | |||
+ | == Architectural Enhancements == | ||
* [[https:// | * [[https:// | ||
* Status: Complex issue; may need to open one or more PRs in order to close this one. | * Status: Complex issue; may need to open one or more PRs in order to close this one. | ||
- | * [[https:// | ||
- | * Status: In review/ | ||
* [[https:// | * [[https:// | ||
* Status: 100 commits so far; many checkboxes still need to be checked. | * Status: 100 commits so far; many checkboxes still need to be checked. | ||
- | * [[https:// | + | * [[https:// |
* Status: Work in progress, with many unchecked checkboxes; some checks have not been completed. | * Status: Work in progress, with many unchecked checkboxes; some checks have not been completed. | ||
* [[https:// | * [[https:// | ||
* Status: Work in progress; has some conflicts and failed checks. | * Status: Work in progress; has some conflicts and failed checks. | ||
- | * [[https:// | ||
- | * Status: This is at an early stage of work, with no significant updates since end of 2022. The branch has conflicts. | ||
- | * [[https:// | ||
- | * Status: Under discussion. | ||
* [[https:// | * [[https:// | ||
* Status: Much work still needed; some checks unsuccessful. | * Status: Much work still needed; some checks unsuccessful. | ||
- | * [[https:// | ||
- | * Status: Discussion underway on GitHub; awaiting response from @mtrojan-ub. | ||
* [[https:// | * [[https:// | ||
* Status: Work in progress; all checks have passed, but branch has conflicts, and more work and review are needed (@crhallberg? | * Status: Work in progress; all checks have passed, but branch has conflicts, and more work and review are needed (@crhallberg? | ||
- | * [[https:// | + | * [[https:// |
- | * Status: Work in progress; | + | * Status: Needs conflict resolution, testing, and consensus-building around package.json strategy. |
+ | * [[https:// | ||
+ | * Status: Minor changes and review still needed. | ||
+ | * [[https:// | ||
+ | * Status: Work in progress; | ||
+ | * [[https:// | ||
+ | * Status: Passed all checks, but needs to have theme conflicts resolved. | ||
+ | * [[https:// | ||
+ | * Status: Work in progress; some checks were unsuccessful and there are theme conflicts. We should figure out what is still needed from this work, as some problems were addressed in a different way. Another look from @crhallberg might help. | ||
+ | |||
+ | == New Features == | ||
* [[https:// | * [[https:// | ||
* Status: Work in progress; all checks have passed. Requires additional testing, documentation, | * Status: Work in progress; all checks have passed. Requires additional testing, documentation, | ||
+ | * [[https:// | ||
+ | * Status: Almost done, just needs a bit more testing and needs some conflicts to be resolved. Needs response from @ThoWagen to suggestion re: simplifying code. | ||
+ | * [[https:// | ||
+ | * Status: One remaining issue; otherwise, all checks passed (but conflicts that need resolving). | ||
+ | * [[https:// | ||
+ | * Status: Work in progress; some checks were unsuccessful. | ||
+ | * [[https:// | ||
+ | * Status: Currently in review. | ||
+ | * [[https:// | ||
+ | * Status: Almost ready to go; will need more attention once #3096 is done. All checks passed, theme and module conflicts need resolution. | ||
+ | * [[https:// | ||
+ | * Status: Under discussion with changes requested; needs review by @jschultze. Some checks were unsuccessful, | ||
+ | * [[https:// | ||
+ | * Status: Almost ready! Needs final review, plus one theme conflict needs resolution. All checks passed. | ||
+ | * [[https:// | ||
+ | * Status: Demian suggests minor adjustments to make this code even more reusable/ | ||
+ | |||
+ | == Smaller Features/ | ||
+ | |||
+ | * [[https:// | ||
+ | * Status: This is at an early stage of work, with no significant updates since end of 2022. The branch has conflicts. | ||
* [[https:// | * [[https:// | ||
* Status: Almost ready to merge; needs final approval, changelog note about need to reindex, and creation of followup PR re: indexing ISO codes. | * Status: Almost ready to merge; needs final approval, changelog note about need to reindex, and creation of followup PR re: indexing ISO codes. | ||
- | * [[https:// | + | * [[https:// |
- | * Status: | + | |
- | * [[https:// | + | * [[https:// |
- | * Status: | + | * Status: |
- | + | * [[https:// | |
- | + | * Status: | |
- | * [[https:// | + | * [[https:// |
- | * Status: | + | * Status: Ready to merge after review by @crhallberg |
- | | + | |
- | * Status: Ready to merge after review by @crhallberg | + | |
* [[https:// | * [[https:// | ||
- | | + | |
- | * [[https:// | + | * [[https:// |
- | | + | * Status: In review |
+ | * [[https:// | ||
+ | * Status: In review | ||
+ | |||
+ | == Specialized PRs Requiring Input from Creators == | ||
+ | |||
+ | * [[https:// | ||
+ | | ||
+ | * [[https:// | ||
+ | * Status: Under discussion. | ||
+ | * [[https:// | ||
+ | * Status: Discussion underway on GitHub; awaiting response from @mtrojan-ub. | ||
+ | * [[https:// | ||
+ | * Status: Work in progress; all checks have passed. PR needs review by @mtrojan-ub. | ||
+ | * [[https:// | ||
+ | * Status: Only a bit more work is needed, now that PR 2982 has been merged. Ready for @elsenhans and @RLangeUni to revisit. | ||
+ | * [[https:// | ||
+ | * Status: Significant work still needed; waiting for @bpalme to make updates. | ||
+ | |||
+ | == General Discussion / Outcomes == | ||
+ | |||
+ | Demian is currently trying to balance addressing newly-added PRs quickly (to resolve small/easy ones immediately and prevent the backlog from growing) with addressing older long-standing PRs (which are being addressed in a roughly oldest-first order). It will take considerable time to get caught up. | ||
+ | |||
+ | Thomas and Maccabee emphasized that they are not in a huge rush to get their PRs resolved. | ||
+ | |||
+ | Ere offered to help with some new feature reviews; Maccabee offered to assist with various front-end infrastructure PRs as needed (though this was not discussed in detail yet because Chris was unable to attend). | ||
+ | |||
+ | Susan will continue to do hands-on testing where possible/ | ||
+ | |||
+ | There was some discussion about tagging and assigning PRs to make management easier. Demian will take some of the suggestions under consideration and apply further classification where possible. | ||
+ | |||
+ | We'll talk about JIRA tickets at a future meeting; first we should focus on triaging the pull requests. | ||
==== 2. Technical Discussion: Theme Development Next Steps / Collaboration ==== | ==== 2. Technical Discussion: Theme Development Next Steps / Collaboration ==== | ||
+ | There was discussion about the increasing need to eliminate Bootstrap 3 due to its end of life status. | ||
+ | |||
+ | Some questions: | ||
+ | |||
+ | * Where should we go next? (Bootstrap upgrade? Other framework? Pure HTML?) | ||
+ | * How much can be abstracted? What abstraction mechanism should we use? (View helper? LESS? Sub-templates? | ||
+ | * How do we balance this with other priorities? | ||
+ | |||
+ | Some thoughts: | ||
+ | |||
+ | * The Doctrine work in progress is touching many template files, so trying to do that at the same time as a full Bootstrap replacement may cause many conflicts and make progress difficult. We may want to prioritize concluding the Doctrine project before attempting other major theme migration work. | ||
+ | * It would be good to assess the scope of Bootstrap usage in the current theme. How many features are we using? How many templates are impacted? What patterns are prevalent in the code? | ||
+ | * Once we have an idea of patterns that need to be addressed, we could begin some proof-of-concept work to come up with solution patterns before fully applying those solutions. | ||
+ | * There may be some situations where modern HTML can address needs previously met by Bootstrap. It is unlikely we can entirely give up framework use, but perhaps we can reduce it -- this should be a goal where practical. | ||
+ | * Abstraction of framework functionality to simplify future customization is a good goal but may be less practical than a simple Bootstrap upgrade. While abstraction would be nice to have, if the best we can do is a reduction of Bootstrap dependency and a straight upgrade, that might be acceptable for this round to keep forward momentum moving. | ||
+ | * Entirely abandoning the bootstrap3 theme all at once would be an inconvenience for many users, but we don't want to have to maintain multiple themes in parallel for a long time. Maybe we could freeze and deprecate bootstrap3 while adding a new theme. We'll have to assess possibilities. | ||
==== 3. Open Q&A / Other Topics? ==== | ==== 3. Open Q&A / Other Topics? ==== | ||
- | None this month. | + | Demian assisted Luke with some Solr troubleshooting. They ran out of time on the meeting and will continue via email. |
===== Next Call ===== | ===== Next Call ===== | ||
community_call/minutes20231107.1698941064.txt.gz · Last modified: 2023/11/02 16:04 by sturkel