Differences

This shows you the differences between two versions of the page.

--- community_call:minutes20240206 [2024/02/06 14:08] – [4. Future of Slack] demiankatz
+++ community_call:minutes20240206 [2024/02/06 15:01] (current) – demiankatz
@@ Line 1: / Line 1: @@
 ====== VuFind® Community Call Minutes: February 6, 2024 ======
-Attending: Chris Hallberg, Demian Katz, Maccabee Levine, Ere Maijala, Peter Murray, Mario Trojan, Susan Turkel, Thomas Wagener
+Attending: Chris Hallberg, Demian Katz, Claas Kazzer, Maccabee Levine, Ere Maijala, Peter Murray, Mario Trojan, Susan Turkel, Thomas Wagener
 ===== Agenda =====
@@ Line 140: / Line 140: @@
 ==== 2. Technical Discussion: Theme Development Next Steps / Collaboration ====
-Discussion point: font size in Sandal theme.
+Discussion point: font size in Sandal theme. The sandal theme default font size is 16px, compared to the original bootstrap3 default font size of 14px.
+Claas approves of the larger font size for the sake of accessibility; he shared [[https://katalog.fid-bbi.de/Search/Results?lookfor=test|this example]] and [[https://katalog.adlr.link/Search/Results?lookfor=font&limit=20|this example]] of instances with large fonts.
+However, Ere pointed out that in the sandal theme, the contrast between large font and small font looks strange in some situations, so maybe some small fonts need to be enlarged.
+Maccabee pointed out that the fixed width of the page is based on decade-old decisions; we should probably consider widening it, which could permit more space for the larger font.
+Chris pointed out that some elements are relative to the base font size, so changing font size may also impact sizing of other controls and elements.
+There was discussion about the relationship between font size and line height and trade-offs between information density and aesthetics.
+General consensus: we'll leave things as they are for now, but we're open to making changes as needed. We should revisit page width, etc., as part of the bootstrap5 theme design (modernize design and technology at the same time).
+Ere pointed out that there are some hard-coded values related to screen width in multiple places; we might want to standardize/unify that.
+Maccabee suggested that we might consider allowing width to stretch more within a range of values instead of hard-coding it to a fixed width.
+Claas mentioned that in their theme, breakpoints have been reduced to just two sizes: large, desktop mode and narrower, tablet/phone mode. This simplification has some advantages.
+Ere pointed out that we can now use flex to achieve good reactivity that was not possible with earlier CSS technology.
+Maccabee mentioned that Lehigh is experimenting with width related to combined search (which has different requirements than other things due to more content in multiple columns).
 ==== 3. Technical Discussion: Javascript Unit Testing? ====
+Chris raised the need for testing our Javascript code in isolation, not just through the integration tests. It might be helpful to use something like jest for this. Chris volunteered to take the lead on this; Demian offered to help with CI integration once the baseline test logic is in place.
+Jest seems to be a favored testing framework: Maccabee pointed out that OLF uses Jest in other projects (FOLIO, etc.). Demian also has Jest experience from other projects (Universal Viewer, VuDL). It's also highly rated in the "State of JS" report.
 ==== 4. Future of Slack ====
@@ Line 148: / Line 173: @@
 ==== 5. Open Q&A / Other Topics? ====
+Demian mentioned that the PHPUnit 10 upgrade was completed and merged today; due to internal changes to the framework, it was necessary to remove the AutoRetryTrait formerly used by Mink tests. Thanks to Ere's test stability improvements, this should not be a major loss.
+Maccabee is having trouble with the spell check component; he is not happy with the results coming from Solr and is interested in whether people have advice on improving the quality of suggestions. Demian mentioned that VuFind's default spell checking is based on the old spelling-index-based method; there was work done at a past Summit to switch to the live lookup method, but it was never contributed back to the project. Ere mentioned that Finna is using custom code to utilize live lookups, but the results are fairly low-quality. One obvious alternative would be to use an external spell-checker, but you still need a mechanism for integrating suggestions with the index to ensure that they will actually yield useful results. Mario speculated that some spelling problems might be the result of interaction between the spelling component and certain filters (stemming, etc.). Ere suggested that looking at the source code may be necessary due to the lack of documentation.
 ===== Next Call =====