Warning: This page has not been updated in over over a year and may be outdated or deprecated.
community_call:minutes20240402
Differences
This shows you the differences between two versions of the page.
Both sides previous revisionPrevious revisionNext revision | Previous revision | ||
community_call:minutes20240402 [2024/04/01 11:16] – demiankatz | community_call:minutes20240402 [2024/04/02 14:13] (current) – demiankatz | ||
---|---|---|---|
Line 1: | Line 1: | ||
====== VuFind® Community Call Minutes: April 2, 2024 ====== | ====== VuFind® Community Call Minutes: April 2, 2024 ====== | ||
- | Attending: | + | Attending: |
===== Agenda ===== | ===== Agenda ===== | ||
Line 14: | Line 14: | ||
Decision: should we set a May release date or defer until June? | Decision: should we set a May release date or defer until June? | ||
+ | |||
+ | Demian proposed releasing 9.1.2 in late April or early May, and 10.0 in June. | ||
+ | |||
+ | Consensus: Monday, June 24th will be the 10.0 release date. We'll set the 9.1.2 date once the outstanding issues (see below) are resolved. | ||
+ | |||
+ | === Pull Request / Ticket Review (release 9.1.2) === | ||
+ | |||
+ | * [[https:// | ||
+ | * Status: Needs review | ||
+ | * [[https:// | ||
+ | * Status: Mathieu plans to submit a PR | ||
=== Pull Request Review (release 10.0) === | === Pull Request Review (release 10.0) === | ||
Line 37: | Line 48: | ||
* Status: In progress | * Status: In progress | ||
* :!: ACTION ITEM: Ere should continue work; others should test as time permits. | * :!: ACTION ITEM: Ere should continue work; others should test as time permits. | ||
+ | * [[https:// | ||
+ | * Status: In discussion/ | ||
+ | * :!: ACTION ITEM: Aleksi and/or Ere should review this. | ||
* [[https:// | * [[https:// | ||
- | * Status: In discussion/ | + | * Status: In discussion/ |
+ | * :!: ACTION ITEM: Aleksi and/or Ere should review this. | ||
* [[https:// | * [[https:// | ||
* Status: In review | * Status: In review | ||
Line 50: | Line 65: | ||
* [[https:// | * [[https:// | ||
* Status: Previously on hold due to autocomplete problems, which have now been fixed. | * Status: Previously on hold due to autocomplete problems, which have now been fixed. | ||
- | * :!: ACTION ITEM: Thomas can resume work now. | + | * :!: ACTION ITEM: Chris should review the latest changes. |
== Smaller Features/ | == Smaller Features/ | ||
+ | * [[https:// | ||
+ | * Status: In review. | ||
+ | * :!: ACTION ITEM: Demian should review latest round of changes. | ||
* [[https:// | * [[https:// | ||
* Status: In review. | * Status: In review. | ||
- | * :!: ACTION ITEM: Waiting for progress from @dmj. | + | * :!: ACTION ITEM: Waiting for progress from @dmj. Demian has requested a status update. |
* [[https:// | * [[https:// | ||
* Status: In review | * Status: In review | ||
* :!: ACTION ITEM: Waiting for progress from @sturkel89 | * :!: ACTION ITEM: Waiting for progress from @sturkel89 | ||
- | * [[https:// | + | * [[https:// |
* Status: In draft mode | * Status: In draft mode | ||
+ | * :!: ACTION ITEM: Needs review/ | ||
== Specialized PRs Requiring Input from Creators == | == Specialized PRs Requiring Input from Creators == | ||
- | |||
- | :!: ACTION ITEM: as the section heading indicates, all of the PRs listed below currently await review resolution or comment responses from the users who created them. | ||
* [[https:// | * [[https:// | ||
- | * Status: Under discussion. | + | * Status: Under discussion; will likely get postponed to a future release unless more input is received. |
* [[https:// | * [[https:// | ||
- | * Status: | + | * Status: |
+ | * :!: ACTION ITEM: @mtrojan-ub | ||
* [[https:// | * [[https:// | ||
- | * Status: | + | * Status: |
+ | * :!: ACTION ITEM: @mtrojan-ub | ||
* [[https:// | * [[https:// | ||
- | * Status: | + | * Status: |
- | * [[https:// | + | |
- | * Status: Work in progress; @bpalme is in the process of making updates. | + | |
=== Scheduled JIRA Tickets (release 10.0) === | === Scheduled JIRA Tickets (release 10.0) === | ||
Line 83: | Line 100: | ||
* [[https:// | * [[https:// | ||
+ | * Status: will probably get pushed forward, but Demian will leave it here for now in case we make progress. | ||
* [[https:// | * [[https:// | ||
+ | * Status: Demian will try to find time to fix this. | ||
* [[https:// | * [[https:// | ||
+ | * ACTION ITEM: Move to 10.1. | ||
* [[https:// | * [[https:// | ||
+ | * Status: Needs more investigation. Can we refactor to a helper? Demian and Ere will evaluate if time permits. If a simple " | ||
* [[https:// | * [[https:// | ||
+ | * Status: Maccabee and Demian will investigate when time permits. | ||
== Smaller Fixes/ | == Smaller Fixes/ | ||
* [[https:// | * [[https:// | ||
+ | * Status: Ere or Demian will try to do this if time permits. | ||
* [[https:// | * [[https:// | ||
+ | * Status: This is an unavoidable problem in Bootstrap 3; we should investigate whether Bootstrap 5 improves the situation. | ||
* [[https:// | * [[https:// | ||
+ | * Status: Demian will work on this if time permits. | ||
* [[https:// | * [[https:// | ||
+ | * Status: Maccabee and Demian will look into if/when time permits. | ||
* [[https:// | * [[https:// | ||
+ | * Status: Chris should investigate. | ||
* [[https:// | * [[https:// | ||
+ | * Status: Chris should investigate. | ||
* [[https:// | * [[https:// | ||
+ | * Status: some parts of this will likely get deferred to future releases, but please review sub-tickets and claim parts that you have time to work on, if possible. | ||
== Test Suite Improvements == | == Test Suite Improvements == | ||
Line 116: | Line 145: | ||
==== 2. Technical Discussion: Theme Development Next Steps / Collaboration ==== | ==== 2. Technical Discussion: Theme Development Next Steps / Collaboration ==== | ||
+ | [[https:// | ||
+ | |||
+ | Outstanding question: we can merge bootstrap5 as-is, but it would also be useful to have an example sub-theme. We don't want to rebase the existing sandal theme on bootstrap5 yet, since bootstrap5 will be " | ||
+ | |||
+ | Demian proposes using " | ||
+ | |||
+ | Outstanding question: where should primary development take place after the merge -- in bootstrap3 with forward-porting, | ||
+ | |||
+ | Ere would like to encourage developers to work in bootstrap5 to help test. | ||
+ | |||
+ | Maccabee emphasized the need to get rid of bootstrap3 so we don't have to maintain both themes forever -- this is intended to occur in release 11.0. | ||
+ | |||
+ | We can create tooling to auto-port templates. Javascript will require manual work. We should build tooling to backport changes from 5 to 3 so that developers are encouraged to work with the new theme. | ||
+ | |||
+ | The only file that cannot be easily auto-ported is the navbar, due to structural changes. Ere will look into renaming this file in bootstrap5 to reduce compatibility problems in a porting tool. | ||
+ | |||
+ | LessToSass conversion needs to be improved -- Ere will look into this. | ||
+ | |||
+ | Ere will work on tooling. | ||
+ | |||
+ | Testing would be appreciated in the near future. Confirmation drop-downs don't look good yet (pending [[https:// | ||
==== 3. Technical Discussion: Database Code Migration Strategy ==== | ==== 3. Technical Discussion: Database Code Migration Strategy ==== | ||
+ | |||
+ | Since it is not possible to complete the Doctrine code migration in time for release 10.0, a more incremental approach is being taken. For 10.0, interfaces are being defined for database entities and services. These interfaces can be applied to existing Laminas\Db code (e.g. implement entity interfaces on Row classes; create Service classes as thin wrappers around Table classes). This allows us to begin refactoring code in a way that will be more Doctrine-compatible while retaining backward compatibility, | ||
+ | |||
+ | Key principles of the refactoring: | ||
+ | |||
+ | * Entity classes should contain no business logic -- they are just data models | ||
+ | * All business logic should live in service classes | ||
+ | * Database service classes are just for reading and writing data; other logic should live in higher-level classes that use database services as dependencies | ||
+ | |||
+ | Some of the Doctrine work-in-progress violates some of these principles (particularly regarding the scope of database service classes); it will be refactored along with dev code as needed. | ||
+ | |||
+ | These changes should not require any database schema changes -- just PHP code reorganization. | ||
==== 4. Future of Slack ==== | ==== 4. Future of Slack ==== | ||
+ | No news this month. | ||
==== 5. Open Q&A / Other Topics? ==== | ==== 5. Open Q&A / Other Topics? ==== | ||
Demian opened [[https:// | Demian opened [[https:// | ||
+ | |||
+ | Maccabee mentioned that the FOLIO community is working on a plan to better communicate breaking API changes. He will keep Demian in the loop. | ||
+ | |||
+ | Mario asked us to review [[https:// | ||
===== Next Call ===== | ===== Next Call ===== | ||
community_call/minutes20240402.txt · Last modified: 2024/04/02 14:13 by demiankatz