Differences

This shows you the differences between two versions of the page.

--- community_call:minutes20240402 [2024/04/02 12:54] – [VuFind® Community Call Minutes: April 2, 2024] demiankatz
+++ community_call:minutes20240402 [2024/04/02 14:13] (current) – demiankatz
@@ Line 1: / Line 1: @@
 ====== VuFind® Community Call Minutes: April 2, 2024 ======
-Attending: Demian Katz, Maccabee Levine
+Attending: Demian Katz, Maccabee Levine, Ere Maijala, Mario Trojan, Thomas Wagener
 ===== Agenda =====
@@ Line 16: / Line 16: @@
 Demian proposed releasing 9.1.2 in late April or early May, and 10.0 in June.
+Consensus: Monday, June 24th will be the 10.0 release date. We'll set the 9.1.2 date once the outstanding issues (see below) are resolved.
 === Pull Request / Ticket Review (release 9.1.2) ===
@@ Line 72: / Line 74: @@
   * [[https://github.com/vufind-org/vufind/pull/3279|#3279]] - Small enhancements to the DefaultRecord class
     * Status: In review.
-      * :!: ACTION ITEM: Waiting for progress from @dmj.
+      * :!: ACTION ITEM: Waiting for progress from @dmj. Demian has requested a status update.
   * [[https://github.com/vufind-org/vufind/pull/3494|#3494]] - Remove redundant language codes; use aliases
     * Status: In review
@@ Line 81: / Line 83: @@
 == Specialized PRs Requiring Input from Creators ==
-:!: ACTION ITEM: as the section heading indicates, all of the PRs listed below currently await review resolution or comment responses from the users who created them.
   * [[https://github.com/vufind-org/vufind/pull/2688|#2688]] - Announce number of search results in title
-    * Status: Under discussion.
+    * Status: Under discussion; will likely get postponed to a future release unless more input is received.
   * [[https://github.com/vufind-org/vufind/pull/2763|#2763]] - SetupThemeResources: Ensure 'Content-Type' is never escaped
-    * Status: Discussion underway on GitHub; awaiting response from @mtrojan-ub.
+    * Status: On hold awaiting more input from the Google Scholar team
+      * :!: ACTION ITEM: @mtrojan-ub will update when he hears back, or close if no response is received.
   * [[https://github.com/vufind-org/vufind/pull/2850|#2850]] - Change route type for Help/Home from Static to Segment
-    * Status: Work in progress; all checks have passed. PR needs review by @mtrojan-ub.
+    * Status: Under discussion.
+      * :!: ACTION ITEM: @mtrojan-ub will review again.
   * [[https://github.com/vufind-org/vufind/pull/2999|#2999]] - Get unique html element id from record view helper
-     * Status: Only a bit more work is needed, now that PR 2982 has been merged. Ready for @elsenhans and @RLangeUni to revisit.
+     * Status: Demian has asked @elsenhans and @RLangeUni for a status update.
 === Scheduled JIRA Tickets (release 10.0) ===
@@ Line 98: / Line 100: @@
   * [[https://openlibraryfoundation.atlassian.net/browse/VUFIND-1614|VUFIND-1614]] - Modernize PubDateVisAjax recommendation module
+    * Status: will probably get pushed forward, but Demian will leave it here for now in case we make progress.
   * [[https://openlibraryfoundation.atlassian.net/browse/VUFIND-1640|VUFIND-1640]] - Eliminate submit inputs named "submit"
+    * Status: Demian will try to find time to fix this.
   * [[https://openlibraryfoundation.atlassian.net/browse/VUFIND-1652|VUFIND-1652]] - Add database support for storing session-specific data
+    * ACTION ITEM: Move to 10.1.
   * [[https://openlibraryfoundation.atlassian.net/browse/VUFIND-1653|VUFIND-1653]] - schema.org markup causes trouble when there are no holdings or reviews
+    * Status: Needs more investigation. Can we refactor to a helper? Demian and Ere will evaluate if time permits. If a simple "disable it by configuration" solution can be implemented for 10.0, we can investigate more nuanced approaches later. There was also discussion about whether or not Google evaluates Javascript before interpreting schema.org markup; Ere's experience suggests that they do, since he has gotten feedback from Google on markup that is only available in an AJAX-loaded record tab.
   * [[https://openlibraryfoundation.atlassian.net/browse/VUFIND-1657|VUFIND-1657]] - Disabling cache fails with EDS backend
+    * Status: Maccabee and Demian will investigate when time permits.
 == Smaller Fixes/Improvements ==
   * [[https://openlibraryfoundation.atlassian.net/browse/VUFIND-1521|VUFIND-1521]] - Add id validation to ILL requests and storage retrieval requests
+    * Status: Ere or Demian will try to do this if time permits.
   * [[https://openlibraryfoundation.atlassian.net/browse/VUFIND-1607|VUFIND-1607]] - Embedded records (in results list) have invalid aria and/or role attributes
+    * Status: This is an unavoidable problem in Bootstrap 3; we should investigate whether Bootstrap 5 improves the situation.
   * [[https://openlibraryfoundation.atlassian.net/browse/VUFIND-1632|VUFIND-1632]] - Improve install.php existing file handling
+    * Status: Demian will work on this if time permits.
   * [[https://openlibraryfoundation.atlassian.net/browse/VUFIND-1651|VUFIND-1651]] - Address Java deprecation of finalize() method in UpdateDateTracker.java
+    * Status: Maccabee and Demian will look into if/when time permits.
   * [[https://openlibraryfoundation.atlassian.net/browse/VUFIND-1658|VUFIND-1658]] - Sandal theme: applied filter contrast is too low on home page
+    * Status: Chris should investigate.
   * [[https://openlibraryfoundation.atlassian.net/browse/VUFIND-1667|VUFIND-1667]] - Modal close button doesn't want to let focus go
+    * Status: Chris should investigate.
   * [[https://openlibraryfoundation.atlassian.net/browse/VUFIND-1668|VUFIND-1668]] - Moravian Library Accessibility Report (Progress Tracking)
+    * Status: some parts of this will likely get deferred to future releases, but please review sub-tickets and claim parts that you have time to work on, if possible.
 == Test Suite Improvements ==
@@ Line 131: / Line 145: @@
 ==== 2. Technical Discussion: Theme Development Next Steps / Collaboration ====
+[[https://github.com/vufind-org/vufind/pull/3545|#3545]] is the last outstanding BS3 PR that we should merge to help finish BS5 work. Demian expects this should be merged very soon; once this is done, Ere can finish the BS5 PR when he returns from vacation.
+Outstanding question: we can merge bootstrap5 as-is, but it would also be useful to have an example sub-theme. We don't want to rebase the existing sandal theme on bootstrap5 yet, since bootstrap5 will be "beta" and we don't want to break the production-level sandal theme.
+Demian proposes using "sandal5" as a temporary solution. We can alias it to sandal (or vice versa) once we phase out bootstrap3.
+Outstanding question: where should primary development take place after the merge -- in bootstrap3 with forward-porting, or in bootstrap5 with backporting?
+Ere would like to encourage developers to work in bootstrap5 to help test.
+Maccabee emphasized the need to get rid of bootstrap3 so we don't have to maintain both themes forever -- this is intended to occur in release 11.0.
+We can create tooling to auto-port templates. Javascript will require manual work. We should build tooling to backport changes from 5 to 3 so that developers are encouraged to work with the new theme.
+The only file that cannot be easily auto-ported is the navbar, due to structural changes. Ere will look into renaming this file in bootstrap5 to reduce compatibility problems in a porting tool.
+LessToSass conversion needs to be improved -- Ere will look into this.
+Ere will work on tooling.
+Testing would be appreciated in the near future. Confirmation drop-downs don't look good yet (pending [[https://github.com/vufind-org/vufind/pull/3545|#3545]] merge) but everything else is expected to be okay. Ere will try to double-check Mink tests before leaving.
 ==== 3. Technical Discussion: Database Code Migration Strategy ====
@@ Line 142: / Line 177: @@
 Some of the Doctrine work-in-progress violates some of these principles (particularly regarding the scope of database service classes); it will be refactored along with dev code as needed.
+These changes should not require any database schema changes -- just PHP code reorganization.
 ==== 4. Future of Slack ====
+No news this month.
 ==== 5. Open Q&A / Other Topics? ====
 Demian opened [[https://openlibraryfoundation.atlassian.net/browse/VUFIND-1666|VUFIND-1666]] to track the Javascript unit testing task discussed at the past two calls.
+Maccabee mentioned that the FOLIO community is working on a plan to better communicate breaking API changes. He will keep Demian in the loop.
+Mario asked us to review [[https://github.com/vufind-org/vufind/pull/3368|#3368]] again. It's now on the 10.0 roadmap.
 ===== Next Call =====