About Features Downloads Getting Started Documentation Events Support GitHub

Love VuFind®? Consider becoming a financial supporter. Your support helps build a better VuFind®!

VuFind Documentation

Site Tools

You are here: start » community_call » minutes20240507
Trace:
Warning: This page has not been updated in over over a year and may be outdated or deprecated.
community_call:minutes20240507

Differences

This shows you the differences between two versions of the page.

Link to this comparison view

Next revision		Previous revision
community_call:minutes20240507 [2024/04/02 18:51] – created demiankatzcommunity_call:minutes20240507 [2024/05/07 15:57] (current) – demiankatz
Line 1: Line 1:
 ====== VuFind® Community Call Minutes: May 7, 2024 ====== ====== VuFind® Community Call Minutes: May 7, 2024 ======
  
-Attending: +Attending: Chris Hallberg, Demian Katz, Maccabee Levine, Luke Magayo, Peter Murray, Mario Trojan, Susan Turkel, Thomas Wagener
  
 +Apologies: Ere Maijala
 ===== Agenda ===== ===== Agenda =====
  
Line 13: Line 14:
 === Pull Request / Ticket Review (release 9.1.2) === === Pull Request / Ticket Review (release 9.1.2) ===
  
-  * [[https://github.com/vufind-org/vufind/pull/3515|#3515]]: CSV importer: Inject dependencies into static callback classes +  * [[https://github.com/vufind-org/vufind/pull/3557|#3557]] - Fix bug: incorrect author link hidden filter in combined search 
-    * Status: Needs review +    * Status: We need to determine if this can be fixed in 9.1.2 or needs to be delayed. 
-  * [[https://openlibraryfoundation.atlassian.net/browse/VUFIND-1680|VUFIND-1680]]: Auth phpCas broken +      * :!: ACTION ITEM: Demian and Ere should discuss 
-    * Status: Mathieu plans to submit a PR+  * [[https://github.com/vufind-org/vufind/pull/3576|#3576]] - Aleph driver: improve ID and date processing 
 +    * Status: Needs review. 
 +      * :!: ACTION ITEM: please review! 
 +  * [[https://github.com/vufind-org/vufind/pull/3635|#3635]] - Initialize head theme resources in combined AJAX responses 
 +    * Status: Needs review. 
 +      * :!: ACTION ITEM: please review!
  
 === Pull Request Review (release 10.0) === === Pull Request Review (release 10.0) ===
Line 25: Line 31:
  
   * [[https://github.com/vufind-org/vufind/pull/1680|#1680]] - Display flash message on login   * [[https://github.com/vufind-org/vufind/pull/1680|#1680]] - Display flash message on login
-     * Status: Complex issue; can be revisited now that [[https://github.com/vufind-org/vufind/pull/3361|#3361]] is resolved.+     * Status: Chris is working on this; we'll determine whether this can be completed in time for 10 based on how the next draft turns out.
        * :!: ACTION ITEM: Chris should determine next steps.        * :!: ACTION ITEM: Chris should determine next steps.
    * [[https://github.com/vufind-org/vufind/pull/2624|#2624]] / [[https://openlibraryfoundation.atlassian.net/browse/VUFIND-1514|VUFIND-1514]] - Replace grunt with NPM scripts    * [[https://github.com/vufind-org/vufind/pull/2624|#2624]] / [[https://openlibraryfoundation.atlassian.net/browse/VUFIND-1514|VUFIND-1514]] - Replace grunt with NPM scripts
-    * Status: We should discuss how to finish this work after the Bootstrap 5 upgrade is complete.+    * Status: Ere thinks we should defer this to 11.0 due to the complexity of the remaining work; it will be easier after bootstrap3 is removed. 
 +      * :!: ACTION ITEM: Change milestone.
   * [[https://github.com/vufind-org/vufind/pull/2723|#2723]] - Component: confirmation menu   * [[https://github.com/vufind-org/vufind/pull/2723|#2723]] - Component: confirmation menu
-     * Status: Needs conflict resolution; many outstanding TODO items. On hold until [[https://github.com/vufind-org/vufind/pull/3545|#3545]] is completed.+     * Status: this is at the top of Chris' list. 
 +       * :!: ACTION ITEM: Chris should try to fix failing tests.
   * [[https://github.com/vufind-org/vufind/pull/2814|#2814]] - Replace jumpMenu controls with menu-button components   * [[https://github.com/vufind-org/vufind/pull/2814|#2814]] - Replace jumpMenu controls with menu-button components
-    * Status: In review+    * Status: this is at the top of Chris' list.
       * :!: ACTION ITEM: Chris should look at style/accessibility improvements and fix test failures       * :!: ACTION ITEM: Chris should look at style/accessibility improvements and fix test failures
   * [[https://github.com/vufind-org/vufind/pull/2934|#2934]] - Switch to Splide Carousel Library   * [[https://github.com/vufind-org/vufind/pull/2934|#2934]] - Switch to Splide Carousel Library
-    * Status: In review +    * Status: Some behavior issues were fixed recently; minor style updates underway. 
-      * :!: ACTION ITEM: Chris should continue work on latest review comments.+      * :!: ACTION ITEM: Chris will continue work; others should test/review.
   * [[https://github.com/vufind-org/vufind/pull/3222|#3222]] - Add bootstrap5 theme   * [[https://github.com/vufind-org/vufind/pull/3222|#3222]] - Add bootstrap5 theme
     * Status: In progress     * Status: In progress
       * :!: ACTION ITEM: Ere should continue work; others should test as time permits.       * :!: ACTION ITEM: Ere should continue work; others should test as time permits.
-  * [[https://github.com/vufind-org/vufind/pull/3539|#3539]] - Add and use VuFind\Db\Service\TagServiceInterface 
-    * Status: In discussion/review 
-      * :!: ACTION ITEM: Aleksi and/or Ere should review this. 
-  * [[https://github.com/vufind-org/vufind/pull/3541|#3541]] - Add more database entity interfaces 
-    * Status: In discussion/review 
-      * :!: ACTION ITEM: Aleksi and/or Ere should review this. 
  
 == New Features == == New Features ==
  
   * [[https://github.com/vufind-org/vufind/pull/3103|#3103]] - Add Notifications CMS functionality   * [[https://github.com/vufind-org/vufind/pull/3103|#3103]] - Add Notifications CMS functionality
-    * Status: Currently in review.+    * Status: Currently in review; likely to get deferred to 10.1.
       * :!: ACTION ITEM: Johannes should continue working on review comments.       * :!: ACTION ITEM: Johannes should continue working on review comments.
   * [[https://github.com/vufind-org/vufind/pull/3226|#3226]] - Adding the option to make html elements sticky   * [[https://github.com/vufind-org/vufind/pull/3226|#3226]] - Adding the option to make html elements sticky
-    * Status: Previously on hold due to autocomplete problems, which have now been fixed.+    * Status: In review
       * :!: ACTION ITEM: Chris should review the latest changes.       * :!: ACTION ITEM: Chris should review the latest changes.
 +  * [[https://github.com/vufind-org/vufind/pull/3634|#3634]] / [[https://openlibraryfoundation.atlassian.net/browse/VUFIND-1653|VUFIND-1653]] - Allow schema.org metadata to be disabled via config
 +    * Status: In review
 +      * :!: ACTION ITEM: Review, please!
 +  * [[https://github.com/vufind-org/vufind/pull/3637|#3637]] - Add support for rate limiting
 +    * Status: This new feature was introduced in response to widespread problems with abusive crawling; even though it is new, we should aim to get it into the release to support users facing these challenges. (Mario mentioned that his team is evaluating mod_security; he's also looking at using change_tracker data to include more accurate history data in sitemaps).
 +      * :!: ACTION ITEM: Demian and Ere will work through the review process; input from others would be appreciated.
  
 == Smaller Features/Enhancements/Fixes == == Smaller Features/Enhancements/Fixes ==
  
-  * [[https://github.com/vufind-org/vufind/pull/3025|#3025]] - Add new Overdrive features 
-    * Status: In review. 
-      * :!: ACTION ITEM: Demian should review latest round of changes. 
   * [[https://github.com/vufind-org/vufind/pull/3279|#3279]] - Small enhancements to the DefaultRecord class   * [[https://github.com/vufind-org/vufind/pull/3279|#3279]] - Small enhancements to the DefaultRecord class
     * Status: In review.     * Status: In review.
Line 67: Line 72:
     * Status: In review     * Status: In review
       * :!: ACTION ITEM: Waiting for progress from @sturkel89       * :!: ACTION ITEM: Waiting for progress from @sturkel89
-  * [[https://github.com/vufind-org/vufind/pull/3534|#3534]] - Fix broken combined AJAX DOI functionality +  * [[https://github.com/vufind-org/vufind/pull/3633|#3633]] - Fix bug: tag links not displaying in favorites 
-    * Status: In draft mode +    * Status: Needs review 
-      * :!: ACTION ITEM: Needs review/discussion (Chris/Demian/Ere)+      * :!: ACTION ITEM: please review 
 +  * [[https://github.com/vufind-org/vufind/pull/3640|#3640]] / [[https://openlibraryfoundation.atlassian.net/browse/VUFIND-1670|VUFIND-1670]] - Accessibility: use heading on spelling suggestions 
 +    * Status: In review 
 +      * :!: ACTION ITEM: Demian will act on Maccabee's feedback
  
 == Specialized PRs Requiring Input from Creators == == Specialized PRs Requiring Input from Creators ==
Line 75: Line 83:
   * [[https://github.com/vufind-org/vufind/pull/2688|#2688]] - Announce number of search results in title   * [[https://github.com/vufind-org/vufind/pull/2688|#2688]] - Announce number of search results in title
     * Status: Under discussion; will likely get postponed to a future release unless more input is received.     * Status: Under discussion; will likely get postponed to a future release unless more input is received.
 +      * :!: ACTION ITEM: move to 10.1 milestone due to inactivity
   * [[https://github.com/vufind-org/vufind/pull/2763|#2763]] - SetupThemeResources: Ensure 'Content-Type' is never escaped   * [[https://github.com/vufind-org/vufind/pull/2763|#2763]] - SetupThemeResources: Ensure 'Content-Type' is never escaped
     * Status: On hold awaiting more input from the Google Scholar team     * Status: On hold awaiting more input from the Google Scholar team
-      * :!: ACTION ITEM: @mtrojan-ub will update when he hears back, or close if no response is received.+      * :!: ACTION ITEM: @mtrojan-ub will close
   * [[https://github.com/vufind-org/vufind/pull/2850|#2850]] - Change route type for Help/Home from Static to Segment   * [[https://github.com/vufind-org/vufind/pull/2850|#2850]] - Change route type for Help/Home from Static to Segment
     * Status: Under discussion.     * Status: Under discussion.
-      * :!: ACTION ITEM: @mtrojan-ub will review again.+      * :!: ACTION ITEM: Demian will move to 10.1 milestone; not urgent.
   * [[https://github.com/vufind-org/vufind/pull/2999|#2999]] - Get unique html element id from record view helper   * [[https://github.com/vufind-org/vufind/pull/2999|#2999]] - Get unique html element id from record view helper
-     * Status: Demian has asked @elsenhans and @RLangeUni for a status update.+     * Status: In progress. 
 +       * :!: ACTION ITEM: @robertlange81 should continue work (expected to happen this week)
  
 === Scheduled JIRA Tickets (release 10.0) === === Scheduled JIRA Tickets (release 10.0) ===
Line 89: Line 99:
  
   * [[https://openlibraryfoundation.atlassian.net/browse/VUFIND-1614|VUFIND-1614]] - Modernize PubDateVisAjax recommendation module   * [[https://openlibraryfoundation.atlassian.net/browse/VUFIND-1614|VUFIND-1614]] - Modernize PubDateVisAjax recommendation module
-    * Status: will probably get pushed forward, but Demian will leave it here for now in case we make progress. +    * Status: no progress yet 
-  * [[https://openlibraryfoundation.atlassian.net/browse/VUFIND-1640|VUFIND-1640]] - Eliminate submit inputs named "submit" +      * :!: ACTION ITEM: move to 10.1 milestone
-    * Status: Demian will try to find time to fix this. +
-  * [[https://openlibraryfoundation.atlassian.net/browse/VUFIND-1653|VUFIND-1653]] - schema.org markup causes trouble when there are no holdings or reviews +
-    * Status: Needs more investigation. Can we refactor to a helper? Demian and Ere will evaluate if time permits. If a simple "disable it by configuration" solution can be implemented for 10.0, we can investigate more nuanced approaches later. There was also discussion about whether or not Google evaluates Javascript before interpreting schema.org markup; Ere's experience suggests that they do, since he has gotten feedback from Google on markup that is only available in an AJAX-loaded record tab. +
-  * [[https://openlibraryfoundation.atlassian.net/browse/VUFIND-1657|VUFIND-1657]] - Disabling cache fails with EDS backend +
-    * Status: Maccabee and Demian will investigate when time permits.+
  
 == Smaller Fixes/Improvements == == Smaller Fixes/Improvements ==
  
   * [[https://openlibraryfoundation.atlassian.net/browse/VUFIND-1521|VUFIND-1521]] - Add id validation to ILL requests and storage retrieval requests   * [[https://openlibraryfoundation.atlassian.net/browse/VUFIND-1521|VUFIND-1521]] - Add id validation to ILL requests and storage retrieval requests
-    * Status: Ere or Demian will try to do this if time permits.+    * Status: Demian reviewed this and couldn't find any missing functionality. 
 +      * :!: ACTION ITEM: Ere should review Demian's comment on the ticket and either close the ticket or clarify the need.
   * [[https://openlibraryfoundation.atlassian.net/browse/VUFIND-1607|VUFIND-1607]] - Embedded records (in results list) have invalid aria and/or role attributes   * [[https://openlibraryfoundation.atlassian.net/browse/VUFIND-1607|VUFIND-1607]] - Embedded records (in results list) have invalid aria and/or role attributes
     * Status: This is an unavoidable problem in Bootstrap 3; we should investigate whether Bootstrap 5 improves the situation.     * Status: This is an unavoidable problem in Bootstrap 3; we should investigate whether Bootstrap 5 improves the situation.
-  * [[https://openlibraryfoundation.atlassian.net/browse/VUFIND-1632|VUFIND-1632]] - Improve install.php existing file handling +      * :!: ACTION ITEM: check Bootstrap 5 situation; decide on next steps
-    * Status: Demian will work on this if time permits.+
   * [[https://openlibraryfoundation.atlassian.net/browse/VUFIND-1651|VUFIND-1651]] - Address Java deprecation of finalize() method in UpdateDateTracker.java   * [[https://openlibraryfoundation.atlassian.net/browse/VUFIND-1651|VUFIND-1651]] - Address Java deprecation of finalize() method in UpdateDateTracker.java
     * Status: Maccabee and Demian will look into if/when time permits.     * Status: Maccabee and Demian will look into if/when time permits.
-  * [[https://openlibraryfoundation.atlassian.net/browse/VUFIND-1658|VUFIND-1658]] - Sandal theme: applied filter contrast is too low on home page 
-    * Status: Chris should investigate. 
   * [[https://openlibraryfoundation.atlassian.net/browse/VUFIND-1667|VUFIND-1667]] - Modal close button doesn't want to let focus go   * [[https://openlibraryfoundation.atlassian.net/browse/VUFIND-1667|VUFIND-1667]] - Modal close button doesn't want to let focus go
     * Status: Chris should investigate.     * Status: Chris should investigate.
   * [[https://openlibraryfoundation.atlassian.net/browse/VUFIND-1668|VUFIND-1668]] - Moravian Library Accessibility Report (Progress Tracking)   * [[https://openlibraryfoundation.atlassian.net/browse/VUFIND-1668|VUFIND-1668]] - Moravian Library Accessibility Report (Progress Tracking)
-    * Status: some parts of this will likely get deferred to future releases, but please review sub-tickets and claim parts that you have time to work on, if possible.+    * Status: Most of this is done, but we should figure out how to complete or reassign the remaining parts.
  
 == Test Suite Improvements == == Test Suite Improvements ==
Line 127: Line 130:
  
   * [[https://openlibraryfoundation.atlassian.net/browse/VUFIND-1645|VUFIND-1645]] - Update dependencies for release 10.0   * [[https://openlibraryfoundation.atlassian.net/browse/VUFIND-1645|VUFIND-1645]] - Update dependencies for release 10.0
 +    * Status: this was done recently, but we will double-check closer to the release date.
   * [[https://openlibraryfoundation.atlassian.net/browse/VUFIND-1659|VUFIND-1659]] - Update GitHub branch protection rules when creating release-10.0 branch   * [[https://openlibraryfoundation.atlassian.net/browse/VUFIND-1659|VUFIND-1659]] - Update GitHub branch protection rules when creating release-10.0 branch
 +    * Status: will do after releasing 9.1.2
 +      * :!: ACTION ITEM: set release date for 9.1.2 first
   * [[https://openlibraryfoundation.atlassian.net/browse/VUFIND-1649|VUFIND-1649]] - Update language translation files for release 10.0   * [[https://openlibraryfoundation.atlassian.net/browse/VUFIND-1649|VUFIND-1649]] - Update language translation files for release 10.0
 +    * Status: will begin about a month before the release date.
 +      * :!: ACTION ITEM: Demian will begin this process on May 20th.
  
 ==== 2. Technical Discussion: Theme Development Next Steps / Collaboration ==== ==== 2. Technical Discussion: Theme Development Next Steps / Collaboration ====
  
 +Ere believes that the Bootstrap5 theme is nearly done. Some accessibility testing is still required, but he believes that it will be more accessible than the bootstrap3 theme even as it is. He has written a [[development:architecture:user_interface:bootstrap5|bootstrap5 wiki page]] to document some of the changes. We should be able to merge it soon; please continue testing as time permits.
 +
 +As noted above, Ere suggested deferring the replacement of Grunt scripts with NPM scripts until 11.0, since rewriting the current scripts required by bootstrap3 will be difficult, and some will no longer be needed once bootstrap3 is removed.
 +
 +We should also document the theme transition plan in the changelog: beta bootstrap5 in 10.0, mature bootstrap5 and deprecated bootstrap3 in 10.1, removal of bootstrap3 in 11.0.
 +
 +Susan raised the question of how sandal vs. sandal5 naming will be addressed during transition; we still need to work out some details there. Right now, the sandal5 theme exists to enable parallel testing of the bootstrap3-based sandal and the bootstrap5-based sandal5. When we get to 10.1, we may need to change the default to sandal5. The question then becomes, do we rename sandal5 to sandal in 11.0, or keep the numbered name? Is there another way forward? We should discuss as things continue to evolve.
 ==== 3. Technical Discussion: Database Code Migration Strategy ==== ==== 3. Technical Discussion: Database Code Migration Strategy ====
 +
 +Demian has made significant progress on introducing database services and entity interfaces, but there is more to do. Any help, particularly with review so that work does not stall, would be greatly appreciated.
  
 ==== 4. Future of Slack ==== ==== 4. Future of Slack ====
  
 +No updates yet from the OLF side; it's taking time to "de-FOLIO" the Slack to make it more suitable for shared use. It's hard to get the momentum to prefix all the names of the existing channels (e.g. change #support to #folio_support, etc., etc.). There's also a need to move the automatic signup system from FOLIO-land to OLF-land. We discussed the possibility of moving VuFind® in before completing the FOLIO renaming, but the auto signup migration is the bare minimum. Peter will work on that part this week, and then we can start working to transition.
 ==== 5. Open Q&A / Other Topics? ==== ==== 5. Open Q&A / Other Topics? ====
  
 +None this month.
 ===== Next Call ===== ===== Next Call =====
  
community_call/minutes20240507.1712083899.txt.gz · Last modified: 2024/04/02 18:51 by demiankatz