Warning: This page has not been updated in over over a year and may be outdated or deprecated.
community_call:minutes20231205
Differences
This shows you the differences between two versions of the page.
Both sides previous revisionPrevious revisionNext revision | Previous revision | ||
community_call:minutes20231205 [2023/12/05 14:20] – [2. Technical Discussion: Theme Development Next Steps / Collaboration] demiankatz | community_call:minutes20231205 [2023/12/05 14:39] (current) – [3. Open Q&A / Other Topics?] demiankatz | ||
---|---|---|---|
Line 101: | Line 101: | ||
Ere explained his work so far on [[https:// | Ere explained his work so far on [[https:// | ||
- | He is currently working on testing integrating Finna' | + | He is currently working on testing integrating Finna' |
The compatibility layer consists of LESS/SCSS to reconcile styles, and Javascript code that makes on-the-fly changes to the HTML to address some changes. Ere plans to open PRs to begin introducing some of these changes directly into the bootstrap3 theme where updates will not break things. | The compatibility layer consists of LESS/SCSS to reconcile styles, and Javascript code that makes on-the-fly changes to the HTML to address some changes. Ere plans to open PRs to begin introducing some of these changes directly into the bootstrap3 theme where updates will not break things. | ||
Line 114: | Line 114: | ||
Another important task is to document the migration process to help others with upgrades. | Another important task is to document the migration process to help others with upgrades. | ||
- | Maccabee suggested running WAVE or other accessibility testing tools against the new branch to make sure nothing has regressed. Ere suggested focusing on Javascript code that sets accessibility-related attributes, since this is an area that has been problematic in the past. Fixes in Bootstrap5 may offer opportunities to simplify and eliminate workarounds. | + | Maccabee suggested running WAVE or other accessibility testing tools against the new branch to make sure nothing has regressed. Ere suggested focusing on Javascript code that sets accessibility-related attributes, since this is an area that has been problematic in the past. Fixes in Bootstrap5 may offer opportunities to simplify and eliminate workarounds. He has added a TODO checkbox to capture this in the PR. Claas will talk to his team to see if they can find time to do some testing of this PR with an eye to accessibility. |
+ | |||
+ | Chris asked about jQuery removal; Bootstrap 5 opens the possibility of eliminating jQuery (it includes its own compatibility layer, though it is imperfect), but more work is definitely needed (particularly in the lightbox) before this is going to be possible. | ||
+ | |||
+ | Chris volunteered to look into JS issues; Maccabee volunteered to look at making some progress on the TODOs in [[https:// | ||
==== 3. Open Q&A / Other Topics? ==== | ==== 3. Open Q&A / Other Topics? ==== | ||
+ | Maccabee asked Thomas about the implications of using [[https:// | ||
+ | Ere noted that this will help answer two kinds of questions -- "why is this here?" and "why is this not where I want it?" The first answer can lead to straightforward solutions; the second answer can get much more complex. He pointed out the need to make it clear that fixing one result set can break other sets -- making changes can have many side effects. He has compiled a list of types of relevance adjustments that are reasonably safe and predictable, | ||
===== Next Call ===== | ===== Next Call ===== | ||
community_call/minutes20231205.1701786054.txt.gz · Last modified: 2023/12/05 14:20 by demiankatz