Warning: This page has not been updated in over over a year and may be outdated or deprecated.
community_call:minutes20240206
Differences
This shows you the differences between two versions of the page.
Both sides previous revisionPrevious revisionNext revision | Previous revision | ||
community_call:minutes20240206 [2024/02/06 14:34] – [2. Technical Discussion: Theme Development Next Steps / Collaboration] demiankatz | community_call:minutes20240206 [2024/02/06 15:01] (current) – demiankatz | ||
---|---|---|---|
Line 152: | Line 152: | ||
There was discussion about the relationship between font size and line height and trade-offs between information density and aesthetics. | There was discussion about the relationship between font size and line height and trade-offs between information density and aesthetics. | ||
- | General consensus: we'll leave things as they are for now, but we're open to making changes as needed. | + | General consensus: we'll leave things as they are for now, but we're open to making changes as needed. We should revisit page width, etc., as part of the bootstrap5 theme design (modernize design and technology at the same time). |
+ | |||
+ | Ere pointed out that there are some hard-coded values related to screen width in multiple places; we might want to standardize/ | ||
+ | |||
+ | Maccabee suggested that we might consider allowing width to stretch more within a range of values instead of hard-coding it to a fixed width. | ||
+ | |||
+ | Claas mentioned that in their theme, breakpoints have been reduced to just two sizes: large, desktop mode and narrower, tablet/ | ||
+ | |||
+ | Ere pointed out that we can now use flex to achieve good reactivity that was not possible with earlier CSS technology. | ||
+ | |||
+ | Maccabee mentioned that Lehigh is experimenting with width related to combined search (which has different requirements than other things due to more content in multiple columns). | ||
==== 3. Technical Discussion: Javascript Unit Testing? ==== | ==== 3. Technical Discussion: Javascript Unit Testing? ==== | ||
+ | Chris raised the need for testing our Javascript code in isolation, not just through the integration tests. It might be helpful to use something like jest for this. Chris volunteered to take the lead on this; Demian offered to help with CI integration once the baseline test logic is in place. | ||
+ | |||
+ | Jest seems to be a favored testing framework: Maccabee pointed out that OLF uses Jest in other projects (FOLIO, etc.). Demian also has Jest experience from other projects (Universal Viewer, VuDL). It's also highly rated in the "State of JS" report. | ||
==== 4. Future of Slack ==== | ==== 4. Future of Slack ==== | ||
Line 160: | Line 173: | ||
==== 5. Open Q&A / Other Topics? ==== | ==== 5. Open Q&A / Other Topics? ==== | ||
+ | Demian mentioned that the PHPUnit 10 upgrade was completed and merged today; due to internal changes to the framework, it was necessary to remove the AutoRetryTrait formerly used by Mink tests. Thanks to Ere's test stability improvements, | ||
+ | |||
+ | Maccabee is having trouble with the spell check component; he is not happy with the results coming from Solr and is interested in whether people have advice on improving the quality of suggestions. Demian mentioned that VuFind' | ||
===== Next Call ===== | ===== Next Call ===== | ||
community_call/minutes20240206.1707230041.txt.gz · Last modified: 2024/02/06 14:34 by demiankatz