Warning: This page has not been updated in over over a year and may be outdated or deprecated.
development:making_pull_requests
Differences
This shows you the differences between two versions of the page.
Both sides previous revisionPrevious revision | |||
development:making_pull_requests [2021/04/13 11:35] – [Making Pull Requests] demiankatz | development:making_pull_requests [2022/04/11 16:16] (current) – [What Happens to a Pull Request] emaijala | ||
---|---|---|---|
Line 58: | Line 58: | ||
* Accessibility | * Accessibility | ||
| | ||
- | You may receive a request for further information or clarification, | + | You may receive a request for further information or clarification, |
+ | |||
+ | If you've done changes requested in a review, please re-request review from the same person. This ensures that the pull request gets attention. | ||
When everything checks out and all requirements are fulfilled, the pull request will get merged. After it has been merged, you can delete your own branch. It's a good idea to clean up obsolete branches regularly. | When everything checks out and all requirements are fulfilled, the pull request will get merged. After it has been merged, you can delete your own branch. It's a good idea to clean up obsolete branches regularly. | ||
Line 101: | Line 103: | ||
---- struct data ---- | ---- struct data ---- | ||
+ | properties.Page Owner : | ||
---- | ---- | ||
development/making_pull_requests.txt · Last modified: 2022/04/11 16:16 by emaijala